From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs-masters@oss.sgi.com" <xfs-masters@oss.sgi.com>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Subject: Re: [xfs-masters] xfs deadlock in stable kernel 3.0.4
Date: Tue, 13 Sep 2011 16:52:22 -0500 [thread overview]
Message-ID: <1315950742.2159.89.camel@doink> (raw)
In-Reply-To: <20110913205018.GA8543@infradead.org>
On Tue, 2011-09-13 at 16:50 -0400, Christoph Hellwig wrote:
> On Tue, Sep 13, 2011 at 08:04:36AM +0200, Stefan Priebe - Profihost AG wrote:
> > I just reported it to the scsi list as i didn't knew where the
> > problems is. But then some people told be it must be a XFS problem.
> >
> > Some more informations:
> > 1.) It's running with 2.6.32 and 2.6.38
> > 2.) I can also write to another ext2 part on the same disk
> > array(aacraid driver) while xfs stucks - so i think it must be an
> > xfs problem
>
> That points a bit more towards XFS, although we've seen storage setups
> create issues depending on the exact workload. The prime culprit for
> used to be the md software RAID driver, though.
>
> > 3.) I've also tried running 3.1-rc5 but then i'm seeing this error:
> >
> > BUG: unable to handle kernel NULL pointer dereference at 000000000000012c
> > IP: [] inode_dio_done+0x4/0x25
>
> Oops, that's a bug that I actually introduced myself. Fix below:
Yikes. I'll prepare that one to send to Linus for 3.1.
I'll wait for your formal signoff, though, Christoph.
Reviewed-by: Alex Elder <aelder@sgi.com>
>
> Index: linux-2.6/fs/xfs/xfs_aops.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/xfs_aops.c 2011-09-13 16:38:47.141089046 -0400
> +++ linux-2.6/fs/xfs/xfs_aops.c 2011-09-13 16:39:09.991647077 -0400
> @@ -1300,6 +1300,7 @@ xfs_end_io_direct_write(
> bool is_async)
> {
> struct xfs_ioend *ioend = iocb->private;
> + struct inode *inode = ioend->io_inode;
>
> /*
> * blockdev_direct_IO can return an error even after the I/O
> @@ -1331,7 +1332,7 @@ xfs_end_io_direct_write(
> }
>
> /* XXX: probably should move into the real I/O completion handler */
> - inode_dio_done(ioend->io_inode);
> + inode_dio_done(inode);
> }
>
> STATIC ssize_t
>
> _______________________________________________
> xfs-masters mailing list
> xfs-masters@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs-masters
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-13 21:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 12:23 xfs deadlock in stable kernel 3.0.4 Stefan Priebe
2011-09-12 15:21 ` Christoph Hellwig
2011-09-12 16:46 ` Stefan Priebe
2011-09-12 20:05 ` Christoph Hellwig
2011-09-13 6:04 ` Stefan Priebe - Profihost AG
2011-09-13 19:31 ` Stefan Priebe - Profihost AG
2011-09-13 20:50 ` Christoph Hellwig
2011-09-13 21:52 ` Alex Elder [this message]
2011-09-13 21:58 ` [xfs-masters] " Alex Elder
2011-09-13 22:26 ` Christoph Hellwig
2011-09-14 7:26 ` Stefan Priebe - Profihost AG
2011-09-14 7:48 ` Stefan Priebe - Profihost AG
2011-09-14 8:49 ` Stefan Priebe - Profihost AG
2011-09-14 14:30 ` Christoph Hellwig
2011-09-14 14:30 ` Christoph Hellwig
2011-09-14 16:06 ` Stefan Priebe - Profihost AG
2011-09-18 9:14 ` Stefan Priebe - Profihost AG
2011-09-18 20:04 ` Christoph Hellwig
2011-09-19 10:54 ` Stefan Priebe - Profihost AG
2011-09-18 23:02 ` Dave Chinner
2011-09-20 0:47 ` Stefan Priebe
2011-09-20 1:01 ` Stefan Priebe
2011-09-20 10:09 ` Stefan Priebe - Profihost AG
2011-09-20 16:02 ` Christoph Hellwig
2011-09-20 17:23 ` Stefan Priebe - Profihost AG
2011-09-20 17:24 ` Christoph Hellwig
2011-09-20 17:35 ` Stefan Priebe - Profihost AG
2011-09-20 22:30 ` Christoph Hellwig
2011-09-21 2:11 ` [xfs-masters] " Dave Chinner
2011-09-21 7:40 ` Stefan Priebe - Profihost AG
2011-09-21 11:42 ` Dave Chinner
2011-09-21 11:55 ` Stefan Priebe - Profihost AG
2011-09-21 12:26 ` Christoph Hellwig
2011-09-21 13:42 ` Stefan Priebe
2011-09-21 16:48 ` Stefan Priebe - Profihost AG
2011-09-21 17:26 ` Stefan Priebe - Profihost AG
2011-09-21 19:01 ` Stefan Priebe - Profihost AG
2011-09-21 23:07 ` Dave Chinner
2011-09-22 14:14 ` Christoph Hellwig
2011-09-22 21:49 ` Dave Chinner
2011-09-22 22:01 ` Christoph Hellwig
2011-09-23 5:28 ` Stefan Priebe - Profihost AG
2011-09-22 0:53 ` Dave Chinner
2011-09-22 5:27 ` Stefan Priebe - Profihost AG
2011-09-22 7:52 ` Stefan Priebe - Profihost AG
2011-09-21 7:36 ` Stefan Priebe - Profihost AG
2011-09-21 11:39 ` Christoph Hellwig
2011-09-21 13:39 ` Stefan Priebe
2011-09-21 14:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315950742.2159.89.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=s.priebe@profihost.ag \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox