From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs: fix a use after free in xfs_end_io_direct_write
Date: Wed, 14 Sep 2011 07:36:16 -0500 [thread overview]
Message-ID: <1316003776.4030.1.camel@doink> (raw)
In-Reply-To: <20110913222600.GA26677@infradead.org>
On Tue, 2011-09-13 at 18:26 -0400, Christoph Hellwig wrote:
> There is a window in which the ioend that we call inode_dio_wake on
> in xfs_end_io_direct_write is already free. Fix this by storing
> the inode pointer in a local variable.
>
> This is a fix for the regression introduced in 3.1-rc by
> "fs: move inode_dio_done to the end_io handler".
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-14 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 22:26 xfs: fix a use after free in xfs_end_io_direct_write Christoph Hellwig
2011-09-14 12:36 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316003776.4030.1.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox