From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix buffer flushing during unmount
Date: Mon, 19 Sep 2011 12:33:20 -0500 [thread overview]
Message-ID: <1316453600.2941.37.camel@doink> (raw)
In-Reply-To: <20110914140826.GA25729@infradead.org>
On Wed, 2011-09-14 at 10:08 -0400, Christoph Hellwig wrote:
> The code to flush buffers in the umount code is a bit iffy: we first flush
> all delwri buffers out, but then might be able to queue up a new one when
> logging the sb counts. On a normal shutdown that one would get flushed
> out when doing the synchronous superblock write in xfs_unmountfs_writesb,
> but we skip that one if the filesystem has been shut down.
>
> Fix this by moving the delwri list flushing until just before unmounting
> the log, and while we're at it also remove the superflous delwri list
> and buffer lru flusing for the rt and log device that can never have
> cached or delwri buffers.
What prevents blocks on a realtime device from being cached?
I haven't looked exhaustively, but it looks like the summary
and bitmap data are operated on without caching, but the
realtime data itself is treated no different from "normal"
data blocks.
Please correct me if I'm wrong about that.
I do agree about the log device not having delwri cached
buffers. Still, it might be good to have this change
done in a different commit from the one that changes
the order of things in xfs_unmountfs().
-Alex
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> Tested-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-19 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 14:08 [PATCH] xfs: fix buffer flushing during unmount Christoph Hellwig
2011-09-19 17:33 ` Alex Elder [this message]
2011-09-28 16:34 ` Christoph Hellwig
2011-10-05 3:55 ` Alex Elder
2011-10-12 4:45 ` Amit Sahrawat
2011-10-16 12:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316453600.2941.37.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox