From: Alex Elder <aelder@sgi.com>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: remove unnecessary #ifdefs
Date: Mon, 19 Sep 2011 16:17:15 -0500 [thread overview]
Message-ID: <1316467035.2941.87.camel@doink> (raw)
In-Reply-To: <1314740824-4231-1-git-send-email-wkendall@sgi.com>
On Tue, 2011-08-30 at 16:47 -0500, Bill Kendall wrote:
> There are a number of #defines in xfsdump that are always enabled and
> no longer need to be conditional code. This patch removes the
> following macros and enables the related code unconditionally:
>
> - SIZEEST is required for multi-stream dumps for determining split
> points.
>
> - RMT, BASED and SESSCPLT are tied to command line options
> (dump/restore -m, dump -B and restore -Q, respectively).
>
> - INVCONVFIX, PIPEINVFIX, and EOMFIX are all related to fixes that
> went in a long time ago.
>
> - WHITEPARSE allows for filenames with spaces and special chars to be
> properly parsed during an interactive restore session.
>
> - DOSOCKS allows Unix domain sockets to be backed up and restored.
> Other special files (block/char devs, FIFOs) are always backed up,
> so do the same for sockets.
>
> Additionally the definition of F_FSSETDM has been removed from
> restore/Makefile since it is never referenced.
Looks good. Sorry it took so long to get to this.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-19 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 21:47 [PATCH] xfsdump: remove unnecessary #ifdefs Bill Kendall
2011-08-31 12:02 ` Christoph Hellwig
2011-09-19 21:17 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316467035.2941.87.camel@doink \
--to=aelder@sgi.com \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox