From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing
Date: Wed, 21 Sep 2011 14:05:34 -0500 [thread overview]
Message-ID: <1316631934.5872.19.camel@doink> (raw)
In-Reply-To: <20110921140603.GA31188@infradead.org>
On Wed, 2011-09-21 at 10:06 -0400, Christoph Hellwig wrote:
> On Mon, Sep 19, 2011 at 10:52:27AM -0500, Alex Elder wrote:
> > On Sun, 2011-09-18 at 16:41 -0400, Christoph Hellwig wrote:
> > > plain text document attachment (xfs-bmalloca-shrink)
> > > Minimise the stack overhead of the remaining stack variables and
> > > structures placed on the stack by packing them without holes. pahole
> > > is used to optimise allocation args structures, stack variables are
> > > done manually.
> > >
> > > [hch: various updates while forward porting the changes]
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > I don't object to it, but I do comment on something
> > below that I think is not an improvement. I'll
> > take this as-is anyway, unless you care to re-submit
> > it.
>
> This one actually breaks test 170, so I'd suggest skipping it for now.
> All the later patches will apply just fine without it.
>
I am testing now using this entire series *without*
this one patch. I have not seen anything unexpected
so far. Dave indicated he was OK with this series
being committed, though he had not done a thorough
review. At this point--unless I encounter some strange
new error as I continue to test this stuff--I am
just waiting for your go-ahead to commit Christoph.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-21 19:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 20:40 [PATCH 00/27] xfs_bmapi split and cleanups V2 Christoph Hellwig
2011-09-18 20:40 ` [PATCH 01/27] xfs: remove the first extent special case in xfs_bmap_add_extent Christoph Hellwig
2011-09-18 20:40 ` [PATCH 02/27] xfs: remove impossible to read code in xfs_bmap_add_extent_delay_real Christoph Hellwig
2011-09-18 20:40 ` [PATCH 03/27] xfs: remove the nextents variable in xfs_bmapi Christoph Hellwig
2011-09-18 20:40 ` [PATCH 04/27] xfs: factor extent map manipulations out of xfs_bmapi Christoph Hellwig
2011-09-18 20:40 ` [PATCH 05/27] xfs: introduce xfs_bmapi_read() Christoph Hellwig
2011-09-18 20:40 ` [PATCH 06/27] xfs: remove xfs_bmapi_single() Christoph Hellwig
2011-09-18 20:40 ` [PATCH 07/27] xfs: factor delalloc reservations out of xfs_bmapi Christoph Hellwig
2011-09-18 20:40 ` [PATCH 08/27] xfs: introduce xfs_bmapi_delay() Christoph Hellwig
2011-09-18 20:40 ` [PATCH 09/27] xfs: do not use xfs_bmap_add_extent for adding delalloc extents Christoph Hellwig
2011-09-18 20:40 ` [PATCH 10/27] xfs: factor extent allocation out of xfs_bmapi Christoph Hellwig
2011-09-18 20:40 ` [PATCH 11/27] xfs: factor unwritten extent map manipulations " Christoph Hellwig
2011-09-18 20:40 ` [PATCH 12/27] xfs: rename xfs_bmapi to xfs_bmapi_write Christoph Hellwig
2011-09-18 20:40 ` [PATCH 13/27] xfs: introduce xfs_bmap_last_extent Christoph Hellwig
2011-09-18 20:40 ` [PATCH 14/27] xfs: remove xfs_bmap_add_extent Christoph Hellwig
2011-09-18 20:40 ` [PATCH 15/27] xfs: pass bmalloca structure to xfs_bmap_isaeof Christoph Hellwig
2011-09-18 20:40 ` [PATCH 16/27] xfs: move extent records into bmalloca structure Christoph Hellwig
2011-09-18 20:40 ` [PATCH 17/27] xfs: move firstblock and bmap freelist cursor " Christoph Hellwig
2011-09-18 20:40 ` [PATCH 18/27] xfs: rename allocation range fields in struct xfs_bmalloca Christoph Hellwig
2011-09-18 20:40 ` [PATCH 19/27] xfs: do not keep local copies of allocation ranges in xfs_bmapi_allocate Christoph Hellwig
2011-09-18 20:41 ` [PATCH 20/27] xfs: move btree cursor into bmalloca Christoph Hellwig
2011-09-18 20:41 ` [PATCH 21/27] xfs: move lastx and nallocs " Christoph Hellwig
2011-09-18 20:41 ` [PATCH 22/27] xfs: move logflags " Christoph Hellwig
2011-09-18 20:41 ` [PATCH 23/27] rearrange bmapi and bmalloca structures for best packing Christoph Hellwig
2011-09-19 15:52 ` Alex Elder
2011-09-21 14:06 ` Christoph Hellwig
2011-09-21 19:05 ` Alex Elder [this message]
2011-09-18 20:41 ` [PATCH 24/27] xfs: pass bmalloca to xfs_bmap_add_extent_delay_real Christoph Hellwig
2011-09-18 20:41 ` [PATCH 25/27] xfs: pass bmalloca to xfs_bmap_add_extent_hole_real Christoph Hellwig
2011-09-18 20:41 ` [PATCH 26/27] xfs: dont ignore error code from xfs_bmbt_update Christoph Hellwig
2011-09-18 20:41 ` [PATCH 27/27] xfs: cleanup xfs_bmap.h Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316631934.5872.19.camel@doink \
--to=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox