From: Alex Elder <aelder@sgi.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2 v3] commit.rc: Add helper for math operation using bc
Date: Fri, 23 Sep 2011 10:00:42 -0500 [thread overview]
Message-ID: <1316790042.2879.38.camel@doink> (raw)
In-Reply-To: <1316787311-23428-1-git-send-email-lczerner@redhat.com>
On Fri, 2011-09-23 at 16:15 +0200, Lukas Czerner wrote:
> Sometimes using bash $(()) math might not be enough due to some
> limitation (big numbers), so add helper using 'bc' program. For
> now the results are only in perfect numbers (as in bash) since this is
> all I need for now.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Clever. This looks OK to me. I'd like to hear what
others think.
If it gets committed maybe we should revisit tests
to see if using this function is warranted elsewhere.
Boris Ranto's recent test (which I am on the verge
of committing) in particular would be better the
way it was originally posted, making use of this.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-23 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 14:15 [PATCH 1/2 v3] commit.rc: Add helper for math operation using bc Lukas Czerner
2011-09-23 14:15 ` [PATCH 2/2] Add test 257: Check proper FITRIM argument handling Lukas Czerner
2011-09-23 15:00 ` Alex Elder
2011-09-23 16:06 ` Lukas Czerner
2011-09-23 23:04 ` Michael Monnerie
2011-09-26 6:15 ` Lukas Czerner
2011-09-26 7:14 ` [PATCH] " Lukas Czerner
2011-09-26 11:42 ` Lukas Czerner
2011-09-26 12:47 ` Alex Elder
2011-09-26 13:52 ` Lukas Czerner
2011-09-26 15:47 ` Alex Elder
2011-09-23 15:00 ` Alex Elder [this message]
2011-09-26 18:45 ` [PATCH v4] commit.rc: Add helper for math operation using bc Lukas Czerner
2011-09-26 21:32 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316790042.2879.38.camel@doink \
--to=aelder@sgi.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox