* [PATCH] xfs: XFS_TRANS_SWAPEXT is not a valid flag for xfs_trans_commit
@ 2011-09-26 9:14 Christoph Hellwig
2011-09-26 12:04 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2011-09-26 9:14 UTC (permalink / raw)
To: xfs
XFS_TRANS_SWAPEXT is a transaction type, not a flag for xfs_trans_commit, so
don't pass it in xfs_swap_extents.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/xfs/xfs_dfrag.c
===================================================================
--- xfs.orig/fs/xfs/xfs_dfrag.c 2011-07-26 17:53:45.336403605 +0200
+++ xfs/fs/xfs/xfs_dfrag.c 2011-07-27 18:48:03.390684228 +0200
@@ -438,7 +438,7 @@ xfs_swap_extents(
if (mp->m_flags & XFS_MOUNT_WSYNC)
xfs_trans_set_sync(tp);
- error = xfs_trans_commit(tp, XFS_TRANS_SWAPEXT);
+ error = xfs_trans_commit(tp, 0);
trace_xfs_swap_extent_after(ip, 0);
trace_xfs_swap_extent_after(tip, 1);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: XFS_TRANS_SWAPEXT is not a valid flag for xfs_trans_commit
2011-09-26 9:14 [PATCH] xfs: XFS_TRANS_SWAPEXT is not a valid flag for xfs_trans_commit Christoph Hellwig
@ 2011-09-26 12:04 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2011-09-26 12:04 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Mon, 2011-09-26 at 05:14 -0400, Christoph Hellwig wrote:
> XFS_TRANS_SWAPEXT is a transaction type, not a flag for xfs_trans_commit, so
> don't pass it in xfs_swap_extents.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-26 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 9:14 [PATCH] xfs: XFS_TRANS_SWAPEXT is not a valid flag for xfs_trans_commit Christoph Hellwig
2011-09-26 12:04 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox