From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8QLWOId219000 for ; Mon, 26 Sep 2011 16:32:24 -0500 Subject: Re: [PATCH v4] commit.rc: Add helper for math operation using bc From: Alex Elder In-Reply-To: <1317062709-2133-1-git-send-email-lczerner@redhat.com> References: <1316787311-23428-1-git-send-email-lczerner@redhat.com> <1317062709-2133-1-git-send-email-lczerner@redhat.com> Date: Mon, 26 Sep 2011 16:32:17 -0500 Message-ID: <1317072737.2925.55.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Lukas Czerner Cc: xfs@oss.sgi.com On Mon, 2011-09-26 at 20:45 +0200, Lukas Czerner wrote: > Sometimes using bash $(()) math might not be enough due to some > limitation (big numbers), so add helper using 'bc' program. For > now the results are only in perfect numbers (as in bash) since this is > all I need for now. > > This commit also adds _require_math() helper which should be called by > every test which uses _math() since it requires "bc" to be installed on > the system. > > Signed-off-by: Lukas Czerner Looks fine. Thanks for updating it. Reviewed-by: Alex Elder _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs