From: Alex Elder <aelder@sgi.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: 259: convert to use the _math() function
Date: Mon, 26 Sep 2011 17:04:59 -0500 [thread overview]
Message-ID: <1317074699.2925.56.camel@doink> (raw)
In-Reply-To: <201109262159.p8QLxZtF016713@stout.americas.sgi.com>
On Mon, 2011-09-26 at 16:59 -0500, Alex Elder wrote:
> Make test 259 a bit more readable by using the new _math() function.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Whoops, substitute "4 TB" for "2 TB" everwhere appropriate... -Alex
> ---
> 259 | 17 ++++++-----------
> 259.out | 12 ++++++------
> 2 files changed, 12 insertions(+), 17 deletions(-)
>
> Index: b/259
> ===================================================================
> --- a/259
> +++ b/259
> @@ -43,20 +43,15 @@ trap "_cleanup ; exit \$status" 0 1 2 3
> _supported_fs xfs
> _supported_os Linux
>
> +_require_math
> +
> testfile=$TEST_DIR/259.image
>
> # Test various sizes slightly less than 4 TB
> -# 4398046511103 = 2^42 - 1
> -# 4398046510592 = 2^42 - 512
> -# 4398046510080 = 2^42 - 1024
> -# 4398046510079 = 2^42 - 1025
> -# 4398046509056 = 2^42 - 2048
> -# 4398046507008 = 2^42 - 4096
> -
> -for ddseek in 4398046511103 4398046510592 4398046510080 \
> - 4398046510079 4398046509056 4398046507008;
> -do
> - echo "Trying to make $ddseek B long xfs fs image"
> +four_TB=$(_math "2^42")
> +for del in 1 512 1024 1025 2048 4096; do
> + ddseek=$(_math "$four_TB - $del")
> + echo "Trying to make (2 TB - $del) B long xfs fs image"
> rm -f "$testfile"
> dd if=/dev/zero "of=$testfile" bs=1 count=0 seek=$ddseek \
> >/dev/null 2>&1 || echo "dd failed"
> Index: b/259.out
> ===================================================================
> --- a/259.out
> +++ b/259.out
> @@ -1,7 +1,7 @@
> QA output created by 259
> -Trying to make 4398046511103 B long xfs fs image
> -Trying to make 4398046510592 B long xfs fs image
> -Trying to make 4398046510080 B long xfs fs image
> -Trying to make 4398046510079 B long xfs fs image
> -Trying to make 4398046509056 B long xfs fs image
> -Trying to make 4398046507008 B long xfs fs image
> +Trying to make (2 TB - 1) B long xfs fs image
> +Trying to make (2 TB - 512) B long xfs fs image
> +Trying to make (2 TB - 1024) B long xfs fs image
> +Trying to make (2 TB - 1025) B long xfs fs image
> +Trying to make (2 TB - 2048) B long xfs fs image
> +Trying to make (2 TB - 4096) B long xfs fs image
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-26 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 21:59 [PATCH] xfstests: 259: convert to use the _math() function Alex Elder
2011-09-26 22:04 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317074699.2925.56.camel@doink \
--to=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox