From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/6] xfsprogs: tolerate mount or project errors
Date: Mon, 3 Oct 2011 09:21:25 -0500 [thread overview]
Message-ID: <1317651685.1972.5.camel@doink> (raw)
In-Reply-To: <20111003133127.GA7875@infradead.org>
On Mon, 2011-10-03 at 09:31 -0400, Christoph Hellwig wrote:
> On Mon, Oct 03, 2011 at 07:49:14AM -0500, Alex Elder wrote:
> > The trouble report that led to fixing this had to do with a
> > situation in which automount left some sort of artifact in the list
> > of mounted filesystems, and any attempt to run xfs_growfs was met
> > with an error that prevented it from being run. The errant entry in
> > /proc/self/mounts contained something like this in the mnt_fsname
> > field returned by getmntent(): "/tmp/auto7fGuI5 (deleted)"
>
> I'd really like to do some sort of QA for this. Given that xfs_quota
> already has an (uncodumented) -t flag to use a replacement for
> /proc/mounts and /etc/mtab this seems fairly easy to do.
Yes I agree, and that's exactly what I intend to do (and how I
was thinking of doing it). I also owe a quota test for the
doubling of what gets reported from a month ago or so. I
thought I could address both issues in the same test (unless
someone feels it's important to have each test have a more
specific focus).
> If you're motivated for even more cleanups it would be good if all
> xfs_quota options are actully documented, and making sure the
> /proc/mounts, /etc/mtab and co handling in xfsprogs doesn't differ
> for different tools. Currently libxcmd, libxfs and xfs_fsr all
> have their own variants.
To be honest I kind of went further with this than I intended
to and I had to sort of put a stop to it... I have three or
four other cleanup patches started but I just have to move on
and so posted what I have working and am content with.
I think what you suggest are all good but for now I'm not
planning to work on them.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-03 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 12:49 [PATCH 0/6] xfsprogs: tolerate mount or project errors Alex Elder
2011-10-03 12:49 ` [PATCH 1/6] xfsprogs: libxcmd: rearrange some routines Alex Elder
2011-10-03 12:49 ` [PATCH 2/6] xfsprogs: libxcmd: avoid using strtok() Alex Elder
2011-10-05 21:58 ` Christoph Hellwig
2011-10-03 12:49 ` [PATCH 3/6] xfsprogs: libxcmd: encapsulate fs_table initialization Alex Elder
2011-10-06 19:42 ` Christoph Hellwig
2011-10-03 12:49 ` [PATCH 4/6] xfsprogs: libxcmd: isolate strdup() calls to fs_table_insert() Alex Elder
2011-10-06 19:45 ` Christoph Hellwig
2011-10-06 19:47 ` Alex Elder
2011-10-03 12:49 ` [PATCH 5/6] xfsprogs: libxcmd: avoid exiting when an error occurs Alex Elder
2011-10-06 19:45 ` Christoph Hellwig
2011-10-03 12:49 ` [PATCH 6/6] xfsprogs: libxcmd: ignore errors when initializing fs_table Alex Elder
2011-10-06 19:47 ` Christoph Hellwig
2011-10-03 13:32 ` [PATCH 1/6] xfsprogs: libxcmd: rearrange some routines Christoph Hellwig
2011-10-03 13:31 ` [PATCH 0/6] xfsprogs: tolerate mount or project errors Christoph Hellwig
2011-10-03 14:21 ` Alex Elder [this message]
2011-10-03 14:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317651685.1972.5.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox