From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: optimize fsync on directories
Date: Tue, 4 Oct 2011 21:23:40 -0500 [thread overview]
Message-ID: <1317781420.2270.4.camel@doink> (raw)
In-Reply-To: <20111002142516.GA6361@infradead.org>
On Sun, 2011-10-02 at 10:25 -0400, Christoph Hellwig wrote:
> Directories are only updated transactionally, which means fsync only
> needs to flush the log the inode is currently dirty, but not bother
> with checking for dirty data, non-transaction updates, an most importanly
> doesn't have to flush disk caches except as part of a transaction commit.
>
> While the first two optimizations can't easily be measured the latter
> actually make a difference when doing lots of fsync that do not actually
> have to commit the inode, e.g. becase an ealier fsync already pushed
> the log far enough.
>
> The new xfs_dir_fsync is identifical to xfs_nfs_commit_metadata except
> for the prototype, but I'm not sure creating a common helper for the
> two is worth it given how simple the functions are.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-10-05 2:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:25 [PATCH] xfs: optimize fsync on directories Christoph Hellwig
2011-10-05 2:23 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317781420.2270.4.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox