From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: simplify xfs_trans_ijoin* again
Date: Tue, 4 Oct 2011 23:09:57 -0500 [thread overview]
Message-ID: <1317787797.2270.11.camel@doink> (raw)
In-Reply-To: <20110919150054.GA21382@infradead.org>
On Mon, 2011-09-19 at 11:00 -0400, Christoph Hellwig wrote:
> There is no reason to keep a reference to the inode even if we unlock
> it during transaction commit because we never drop a reference between
> the ijoin and commit. Also use this fact to merge xfs_trans_ijoin_ref
> back into xfs_trans_ijoin - the third argument decides if an unlock
> is needed now.
>
> I'm actually starting to wonder if allowing inodes to be unlocked
> at transaction commit really is worth the effort. The only real
> benefit is that they can be unlocked earlier when commiting a
> synchronous transactions, but that could be solved by doing the
> log force manually after the unlock, too.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-10-05 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 15:00 [PATCH] xfs: simplify xfs_trans_ijoin* again Christoph Hellwig
2011-10-05 4:09 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317787797.2270.11.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox