From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries
Date: Thu, 6 Oct 2011 15:14:30 -0500 [thread overview]
Message-ID: <1317932070.2870.33.camel@doink> (raw)
In-Reply-To: <20111006194913.GF13434@infradead.org>
On Thu, 2011-10-06 at 15:49 -0400, Christoph Hellwig wrote:
> > +mtab=/proc/self/mounts
> > +if [ ! -r "${mtab}" ]; then
> > + mtab=/etc/mtab
> > + if [ ! -r "${mtab}" ]; then
> > + echo "warning: proceeding without use of mount table" >&2
> > + fi
> > +fi
>
> Just use /proc/self/mounts unconditionally, it's been there for a long
> time.
OK. I was just following the logic embedded in libxcmd
but I do prefer keeping it simple.
-Alex
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-10-06 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 23:01 [PATCH] xfstests: 261: test failures caused by bogus mtab entries Alex Elder
2011-10-06 19:49 ` Christoph Hellwig
2011-10-06 20:14 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317932070.2870.33.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox