Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale

Dave Chinner
2011-10-07T01:45:41Z

On Thu, Oct 06, 2011 at 05:06:12PM -0400, Christoph Hellwig wrote:
> For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either
> directly before or after it, or are guaranteed by the surrounding
> conditionals that we are never called on delwri buffers. Simply
> this situation by moving the call to xfs_buf_delwri_dequeue into
> xfs_buf_stale.

Makes sense, and delwri-dequeue is safe to call on non-delwri
buffers.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com