Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale

Alex Elder
2011-10-07T19:39:12Z

On Thu, 2011-10-06 at 17:06 -0400, Christoph Hellwig wrote:
> For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either
> directly before or after it, or are guaranteed by the surrounding
> conditionals that we are never called on delwri buffers. Simply
> this situation by moving the call to xfs_buf_delwri_dequeue into
> xfs_buf_stale.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I see 6 or so spots where xfs_buf_stale() is (was) called with no call
to xfs_buf_delwri_dequeue(). This adds such a call, but it looks to me
like that's OK.

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>