From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>, chinner@redhat.com
Cc: Stefan Priebe <s.priebe@profihost.ag>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: revert to using a kthread for AIL pushing
Date: Fri, 7 Oct 2011 17:18:20 -0500 [thread overview]
Message-ID: <1318025900.2810.79.camel@doink> (raw)
In-Reply-To: <20111006183549.770414484@bombadil.infradead.org>
On Thu, 2011-10-06 at 14:33 -0400, Christoph Hellwig wrote:
> Currently we have a few issues with the way the workqueue code is used to
> implement AIL pushing:
>
> - it accidentally uses the same workqueue as the syncer action, and thus
> can be prevented from running if there are enough sync actions active
> in the system.
> - it doesn't use the HIGHPRI flag to queue at the head of the queue of
> work items
>
> At this point I'm not confident enough in getting all the workqueue flags and
> tweaks right to provide a perfectly reliable execution context for AIL
> pushing, which is the most important piece in XFS to make forward progress
> when the log fills.
>
> Revert back to use a kthread per filesystem which fixes all the above issues
> at the cost of having a task struct and stack around for each mounted
> filesystem. In addition this also gives us much better ways to diagnose
> any issues involving hung AIL pushing and removes a small amount of code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Stefan Priebe <s.priebe@profihost.ag>
> Tested-by: Stefan Priebe <s.priebe@profihost.ag>
Looks good. Dave, I don't want to commit this (series) until you
have had a chance to review it.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-07 22:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 18:32 [PATCH 0/4] fix AIL pushing under heavy concurrent metadata loads Christoph Hellwig
2011-10-06 18:32 ` [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items Christoph Hellwig
2011-10-07 22:18 ` Alex Elder
2011-10-10 1:37 ` Dave Chinner
2011-10-06 18:32 ` [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf Christoph Hellwig
2011-10-07 22:18 ` Alex Elder
2011-10-10 1:39 ` Dave Chinner
2011-10-06 18:33 ` [PATCH 3/4] xfs: revert to using a kthread for AIL pushing Christoph Hellwig
2011-10-07 22:18 ` Alex Elder [this message]
2011-10-10 1:45 ` Dave Chinner
2011-10-10 5:55 ` Markus Trippelsdorf
2011-10-10 6:06 ` Stefan Priebe - Profihost AG
2011-10-10 13:26 ` Christoph Hellwig
2011-10-10 18:37 ` Tejun Heo
2011-10-19 11:16 ` Stefan Priebe - Profihost AG
2011-10-19 11:34 ` Christoph Hellwig
2011-10-19 13:10 ` Stefan Priebe - Profihost AG
2011-10-06 18:33 ` [PATCH 4/4] xfs: add AIL pushing tracepoints Christoph Hellwig
2011-10-07 22:18 ` Alex Elder
2011-10-10 1:45 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-10-11 15:14 [PATCH 0/4] fix AIL pushing under heavy concurrent metadata loads V2 Christoph Hellwig
2011-10-11 15:14 ` [PATCH 3/4] xfs: revert to using a kthread for AIL pushing Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318025900.2810.79.camel@doink \
--to=aelder@sgi.com \
--cc=chinner@redhat.com \
--cc=hch@infradead.org \
--cc=s.priebe@profihost.ag \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox