Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems

Christoph Hellwig
2011-10-09T23:52:42Z

On Mon, Oct 10, 2011 at 10:11:46AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Because repair uses direct IO, it cannot do IO smaller than a sector
> on the underlying device. When repairing a filesystem image, the
> filesystem hosting the image may have a sector size larger than the
> sector size of the image, and so single image sector reads and
> writes will fail.

Does it? Given that the loop driver uses buffered I/O that would be
unexpected behaviour. I'll try to reproduce it as soon as my 4k
disk is available again.