Re: [PATCH 4/5] repair: don't cache large blkmap allocations

Dave Chinner
2011-10-10T00:14:05Z

On Sun, Oct 09, 2011 at 07:48:09PM -0400, Christoph Hellwig wrote:
> > + /* consider more than 100k extents rare */
> > + if (blkmap->naexts < 100 * 1024)
> > + return;
>
> 100k extents still seems like a fairly high number. Otherwise looks
> okay.

But not unreasonable for a filesystem full of torrents ;)

> (If only we had a non-sucky threaded memory allocator in userspace..)

Perhaps we should look at the talloc code from ccan?

Cheers,

Dave.

--
Dave Chinner
david@fromorbit.com