From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg
Date: Mon, 10 Oct 2011 23:04:14 -0500 [thread overview]
Message-ID: <1318305854.3804.4.camel@doink> (raw)
In-Reply-To: <20111010165328.386947740@bombadil.infradead.org>
On Mon, 2011-10-10 at 12:52 -0400, Christoph Hellwig wrote:
> plain text document attachment
> (xfs-stop-flushing-data-wqs-in-xfs_flush_buftarg)
> When we call xfs_flush_buftarg (generally from sync or umount) it already
> is too late to flush the data workqueues, as I/O completion is signalled
> for them and we are thus already done with the data we would flush here.
>
> There are places where flushing them might be useful, but the current
> sync interface doesn't give us that opportunity.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
This looks fine to me for now but I'm going to review it
again in the morning. I'll be testing with it overnight
though.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-11 4:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 16:52 [PATCH 00/11] a couple of buffer cache cleanups V2 Christoph Hellwig
2011-10-10 16:52 ` [PATCH 01/11] xfs: remove xfs_get_buftarg_list Christoph Hellwig
2011-10-10 16:52 ` [PATCH 02/11] xfs: remove XFS_BUF_FINISH_IOWAIT Christoph Hellwig
2011-10-10 16:52 ` [PATCH 03/11] xfs: remove XFS_BUF_SET_VTYPE and XFS_BUF_SET_VTYPE_REF Christoph Hellwig
2011-10-10 16:52 ` [PATCH 04/11] xfs: remove XFS_BUF_STALE and XFS_BUF_SUPER_STALE Christoph Hellwig
2011-10-10 16:52 ` [PATCH 05/11] xfs: remove buffers from the delwri list in xfs_buf_stale Christoph Hellwig
2011-10-10 16:52 ` [PATCH 06/11] xfs: clean up buffer allocation Christoph Hellwig
2011-10-10 16:52 ` [PATCH 07/11] xfs: clean up xfs_ioerror_alert Christoph Hellwig
2011-10-10 16:52 ` [PATCH 08/11] xfs: use xfs_ioerror_alert in xfs_buf_iodone_callbacks Christoph Hellwig
2011-10-10 16:52 ` [PATCH 09/11] xfs: remove xfs_buf_target_name Christoph Hellwig
2011-10-10 16:52 ` [PATCH 10/11] xfs: remove XFS_bflush Christoph Hellwig
2011-10-11 2:07 ` Dave Chinner
2011-10-11 4:03 ` Alex Elder
2011-10-10 16:52 ` [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg Christoph Hellwig
2011-10-11 4:04 ` Alex Elder [this message]
2011-10-11 19:04 ` Alex Elder
2011-10-11 22:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318305854.3804.4.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox