From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p9D9vsqw162798 for ; Thu, 13 Oct 2011 04:57:54 -0500 Subject: Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems From: Alex Elder In-Reply-To: <1318208915-14975-2-git-send-email-david@fromorbit.com> References: <1318208915-14975-1-git-send-email-david@fromorbit.com> <1318208915-14975-2-git-send-email-david@fromorbit.com> Date: Thu, 13 Oct 2011 04:57:49 -0500 Message-ID: <1318499869.3172.8.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, 2011-10-10 at 12:08 +1100, Dave Chinner wrote: > From: Dave Chinner > > Because repair uses direct IO, it cannot do IO smaller than a sector > on the underlying device. When repairing a filesystem image, the > filesystem hosting the image may have a sector size larger than the > sector size of the image, and so single image sector reads and > writes will fail. > > To avoid this, when checking a file and there is a sector size > mismatch like this, turn off direct IO. While there, fix a compile > bug in the IO_DEBUG option for libxfs which was found during triage. > > Signed-off-by: Dave Chinner Looks good. Reviewed-by: Alex Elder _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs