From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfstests: make 225 use SCRATCH_DEV
Date: Thu, 13 Oct 2011 05:35:33 -0500 [thread overview]
Message-ID: <1318502133.3172.18.camel@doink> (raw)
In-Reply-To: <1318212855-20212-2-git-send-email-david@fromorbit.com>
On Mon, 2011-10-10 at 13:14 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Use the scratch device for test 225 so that both custom mkfs and
> mount options impact the test (e.g. filesystem block size). This
> exposes test failures when using 512 byte block sizes, which
> currently not tested unless the test device is specifically created
> with a 512 byte block size.
>
> Also clean up the file names to include the test number, and don't
> remove the test files after the test has finished so that it leaves
> behind a corpse that can be dissected when the test fails.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-13 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 2:14 [PATCH 0/2] xfstests: test different block sizes in a couple of tests Dave Chinner
2011-10-10 2:14 ` [PATCH 1/2] xfstests: make 225 use SCRATCH_DEV Dave Chinner
2011-10-10 16:27 ` Christoph Hellwig
2011-10-13 10:35 ` Alex Elder [this message]
2011-10-10 2:14 ` [PATCH 2/2] xfstests: make 203 pass on non-default block size filesystems Dave Chinner
2011-10-10 16:27 ` Christoph Hellwig
2011-10-13 10:35 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318502133.3172.18.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox