public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] xfstests: fix 122 for recent xfsprogs
@ 2011-10-10 18:21 Christoph Hellwig
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-10 18:21 UTC (permalink / raw)
  To: xfs

 - filter out xfs_alloctype_t, this was an internal emum that got removed
 - filter out xfs_bmbt_rec_32_t, this is a variant of the xfs_bmbt_rec_t
   that had almost no users and was removed
 - filter out xfs_dinode_core_t, the separate dinode core is gone, and just
   checking the size of the full dinode is enough
 - accept xfs_bmbt_rec_t as the new canonical name for xfs_bmbt_rec_64_t,
   and replace the old name with the new one in the output stream.

Signed-off-by: Christoph Hellwig <hch@lst.de>


Index: xfstests-dev/122
===================================================================
--- xfstests-dev.orig/122	2011-10-10 16:49:06.000000000 +0000
+++ xfstests-dev/122	2011-10-10 17:04:07.000000000 +0000
@@ -57,6 +57,12 @@ s/sizeof\( xfs_agf_t \) = 64/sizeof( xfs
 	fi
 }
 
+# filter out known changes to xfs type names
+_type_name_filter()
+{
+	sed -e 's/xfs_bmbt_rec_64_t/xfs_bmbt_rec_t/'
+}
+
 _attribute_filter()
 {
 	sed -e 's/__attribute__ *[(][(]packed[)][)]//' \
@@ -73,7 +79,9 @@ cat >$cprog <<EOF
 EOF
 
 cat >$tmp.ignore <<EOF
+xfs_alloctype_t
 xfs_buf_cancel_t
+xfs_bmbt_rec_32_t
 xfs_swapext_t
 xfs_dirops_t
 xfs_efi_log_item_t
@@ -160,6 +168,7 @@ xfs_log_item_chunk_t
 xfs_trans_t
 xfs_dirent_t
 xfs_fsop_getparents_handlereq_t
+xfs_dinode_core_t
 EOF
 
 echo 'int main(int argc, char *argv[]) {' >>$cprog
@@ -193,7 +202,7 @@ echo 'return 0; }' >>$cprog
 # create and run program
 cc -o $oprog $cprog >> $seq.full 2>&1 || \
   _notrun "Could not compile test program (see end of $seq.full)"
-$oprog | _type_size_filter > $progout
+$oprog | _type_size_filter | _type_name_filter > $progout
 
 #
 # add addition sizes and xfs_sb_t fields that don't exist in the version
Index: xfstests-dev/122.out
===================================================================
--- xfstests-dev.orig/122.out	2011-10-10 16:53:08.000000000 +0000
+++ xfstests-dev/122.out	2011-10-10 16:56:59.000000000 +0000
@@ -50,7 +50,6 @@ sizeof( xfs_agfl_t ) = 4
 sizeof( xfs_agi_t ) = 296
 sizeof( xfs_alloc_rec_incore_t ) = 8
 sizeof( xfs_alloc_rec_t ) = 8
-sizeof( xfs_alloctype_t ) = 4
 sizeof( xfs_attr_inactive_list_t ) = 8
 sizeof( xfs_attr_leaf_entry_t ) = 8
 sizeof( xfs_attr_leaf_hdr_t ) = 32
@@ -61,14 +60,12 @@ sizeof( xfs_attr_leafblock_t ) = 56
 sizeof( xfs_attr_shortform_t ) = 8
 sizeof( xfs_attrlist_cursor_t ) = 16
 sizeof( xfs_bmbt_key_t ) = 8
-sizeof( xfs_bmbt_rec_32_t ) = 16
-sizeof( xfs_bmbt_rec_64_t ) = 16
+sizeof( xfs_bmbt_rec_t ) = 16
 sizeof( xfs_bmdr_block_t ) = 4
 sizeof( xfs_btnum_t ) = 4
 sizeof( xfs_buf_log_format_t ) = 24
 sizeof( xfs_da_blkinfo_t ) = 12
 sizeof( xfs_da_intnode_t ) = 24
-sizeof( xfs_dinode_core_t ) = 96
 sizeof( xfs_dinode_fmt_t ) = 4
 sizeof( xfs_dir2_data_free_t ) = 4
 sizeof( xfs_dir2_data_hdr_t ) = 16

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
  2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
@ 2011-10-10 18:22 ` Christoph Hellwig
  2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
                     ` (2 more replies)
  2011-10-11 22:36 ` [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Dave Chinner
  2011-10-13 11:06 ` Alex Elder
  2 siblings, 3 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-10 18:22 UTC (permalink / raw)
  To: xfs

This effectively reverts

	xfstests: add mapped write fsx operations to 091

and adds a new test case for it.  It tests something slightly different, and
regressions in existing tests due to new features are pretty nasty in a
test suite.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/263
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/263	2011-10-10 18:06:59.000000000 +0000
@@ -0,0 +1,64 @@
+#! /bin/bash
+# FS QA Test No. 263
+#
+# fsx exercising direct IO vs sub-block buffered I/O
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+# creator
+owner=nathans@sgi.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+rm -f $seq.full
+
+run_fsx()
+{
+	echo fsx $@ | tee -a $seq.full
+	args=`echo $@ | sed -e "s/ BSIZE / $bsize /g" -e "s/ PSIZE / $psize /g"`
+	rm -f $TEST_DIR/junk
+	$here/ltp/fsx $args $TEST_DIR/junk >>$seq.full 2>&1
+	if [ $? -ne 0 ]; then
+		cat $seq.full
+		exit 1
+	fi
+}
+
+psize=`$here/src/feature -s`
+bsize=`blockdev --getss $TEST_DEV`
+
+run_fsx -N 10000  -o 8192   -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
+run_fsx -N 10000  -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
+
+status=0
+exit
Index: xfstests-dev/group
===================================================================
--- xfstests-dev.orig/group	2011-10-10 18:04:52.000000000 +0000
+++ xfstests-dev/group	2011-10-10 18:05:02.000000000 +0000
@@ -376,3 +376,4 @@ deprecated
 260 auto quick trim
 261 auto quick quota
 262 auto quick quota
+263 rw auto quick
Index: xfstests-dev/263.out
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/263.out	2011-10-10 18:07:16.000000000 +0000
@@ -0,0 +1,3 @@
+QA output created by 263
+fsx -N 10000 -o 8192 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
+fsx -N 10000 -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
Index: xfstests-dev/091
===================================================================
--- xfstests-dev.orig/091	2011-10-10 18:07:46.000000000 +0000
+++ xfstests-dev/091	2011-10-10 18:07:51.000000000 +0000
@@ -88,11 +88,5 @@ kernel=`uname -r  | sed -e 's/\(2\..\).*
 #run_fsx -N 10000  -o 128000 -l 500000 -r PSIZE -t PSIZE -w PSIZE -Z -W
  run_fsx -N 10000  -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z -W
 
- run_fsx -N 10000  -o 8192   -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
- run_fsx -N 10000  -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
-
-# Commented out calls above are less likely to pick up issues, so
-# save time by commenting them out (leave 'em for manual testing).
-
 status=0
 exit
Index: xfstests-dev/091.out
===================================================================
--- xfstests-dev.orig/091.out	2011-10-10 18:07:53.000000000 +0000
+++ xfstests-dev/091.out	2011-10-10 18:07:55.000000000 +0000
@@ -5,5 +5,3 @@ fsx -N 10000 -o 32768 -l 500000 -r PSIZE
 fsx -N 10000 -o 8192 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z -R -W
 fsx -N 10000 -o 32768 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z -R -W
 fsx -N 10000 -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z -W
-fsx -N 10000 -o 8192 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z
-fsx -N 10000 -o 128000 -l 500000 -r PSIZE -t BSIZE -w BSIZE -Z

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
@ 2011-10-10 18:22   ` Christoph Hellwig
  2011-10-11  2:11     ` Dave Chinner
  2011-10-11 14:18     ` [PATCH 3/3 v2] " Christoph Hellwig
  2011-10-11 22:40   ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
  2011-10-13 11:06   ` Alex Elder
  2 siblings, 2 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-10 18:22 UTC (permalink / raw)
  To: xfs

The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
btrfs fails it, but that looks a like a btrfs-specific issue to me.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/091
===================================================================
--- xfstests-dev.orig/091	2011-10-10 18:09:20.000000000 +0000
+++ xfstests-dev/091	2011-10-10 18:09:41.000000000 +0000
@@ -37,7 +37,7 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
 . ./common.filter
 
 # real QA test starts here
-_supported_fs xfs
+_supported_fs generic
 _supported_os Linux IRIX
 
 [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems
  2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
@ 2011-10-11  2:11     ` Dave Chinner
  2011-10-11 12:46       ` Christoph Hellwig
  2011-10-11 14:18     ` [PATCH 3/3 v2] " Christoph Hellwig
  1 sibling, 1 reply; 14+ messages in thread
From: Dave Chinner @ 2011-10-11  2:11 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Mon, Oct 10, 2011 at 02:22:33PM -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfstests-dev/091
> ===================================================================
> --- xfstests-dev.orig/091	2011-10-10 18:09:20.000000000 +0000
> +++ xfstests-dev/091	2011-10-10 18:09:41.000000000 +0000
> @@ -37,7 +37,7 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
>  . ./common.filter
>  
>  # real QA test starts here
> -_supported_fs xfs
> +_supported_fs generic
>  _supported_os Linux IRIX
>  
>  [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

Given that the test is not run on irix, I'd change the _supported_os
line to just Linux as well, and kill the separate check for Irix
while you are there.

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems
  2011-10-11  2:11     ` Dave Chinner
@ 2011-10-11 12:46       ` Christoph Hellwig
  0 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-11 12:46 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs

> Given that the test is not run on irix, I'd change the _supported_os
> line to just Linux as well, and kill the separate check for Irix
> while you are there.

Ok.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 3/3 v2] xfstests: allow 091 for non-xfs filesystems
  2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
  2011-10-11  2:11     ` Dave Chinner
@ 2011-10-11 14:18     ` Christoph Hellwig
  2011-10-11 22:40       ` Dave Chinner
  2011-10-13 11:06       ` Alex Elder
  1 sibling, 2 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-11 14:18 UTC (permalink / raw)
  To: xfs

The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
btrfs fails it, but that looks a like a btrfs-specific issue to me.

Also use _supported_os properly instead of erroring out manually on
IRIX.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/091
===================================================================
--- xfstests-dev.orig/091	2011-10-10 18:09:20.000000000 +0000
+++ xfstests-dev/091	2011-10-11 14:12:00.000000000 +0000
@@ -37,10 +37,8 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
 . ./common.filter
 
 # real QA test starts here
-_supported_fs xfs
-_supported_os Linux IRIX
-
-[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
+_supported_fs generic
+_supported_os Linux
 
 rm -f $seq.full
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/3] xfstests: fix 122 for recent xfsprogs
  2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
@ 2011-10-11 22:36 ` Dave Chinner
  2011-10-13 11:06 ` Alex Elder
  2 siblings, 0 replies; 14+ messages in thread
From: Dave Chinner @ 2011-10-11 22:36 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Mon, Oct 10, 2011 at 02:21:56PM -0400, Christoph Hellwig wrote:
>  - filter out xfs_alloctype_t, this was an internal emum that got removed
>  - filter out xfs_bmbt_rec_32_t, this is a variant of the xfs_bmbt_rec_t
>    that had almost no users and was removed
>  - filter out xfs_dinode_core_t, the separate dinode core is gone, and just
>    checking the size of the full dinode is enough
>  - accept xfs_bmbt_rec_t as the new canonical name for xfs_bmbt_rec_64_t,
>    and replace the old name with the new one in the output stream.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
  2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
@ 2011-10-11 22:40   ` Dave Chinner
  2011-10-12  7:32     ` Christoph Hellwig
  2011-10-13 11:06     ` Alex Elder
  2011-10-13 11:06   ` Alex Elder
  2 siblings, 2 replies; 14+ messages in thread
From: Dave Chinner @ 2011-10-11 22:40 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Mon, Oct 10, 2011 at 02:22:16PM -0400, Christoph Hellwig wrote:
> This effectively reverts
> 
> 	xfstests: add mapped write fsx operations to 091
> 
> and adds a new test case for it.  It tests something slightly different, and
> regressions in existing tests due to new features are pretty nasty in a
> test suite.

Makes sense.

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfstests-dev/263
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/263	2011-10-10 18:06:59.000000000 +0000
> @@ -0,0 +1,64 @@
> +#! /bin/bash
> +# FS QA Test No. 263
> +#
> +# fsx exercising direct IO vs sub-block buffered I/O
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=nathans@sgi.com

No point keeping an invalid email address as the owner of a new
test.

FWIW, I'm considering removing this from the tests as the
information is in the commit history, and the use of the field
(emailing the owner when the automated test infrastructure SGI used
10 years ago failed) is no longer used...

Otherwise looks OK.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3 v2] xfstests: allow 091 for non-xfs filesystems
  2011-10-11 14:18     ` [PATCH 3/3 v2] " Christoph Hellwig
@ 2011-10-11 22:40       ` Dave Chinner
  2011-10-13 11:06       ` Alex Elder
  1 sibling, 0 replies; 14+ messages in thread
From: Dave Chinner @ 2011-10-11 22:40 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Tue, Oct 11, 2011 at 10:18:40AM -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
> 
> Also use _supported_os properly instead of erroring out manually on
> IRIX.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
  2011-10-11 22:40   ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
@ 2011-10-12  7:32     ` Christoph Hellwig
  2011-10-13 11:06     ` Alex Elder
  1 sibling, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2011-10-12  7:32 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Christoph Hellwig, xfs

On Wed, Oct 12, 2011 at 09:40:10AM +1100, Dave Chinner wrote:
> > +# creator
> > +owner=nathans@sgi.com
> 
> No point keeping an invalid email address as the owner of a new
> test.
> 
> FWIW, I'm considering removing this from the tests as the
> information is in the commit history, and the use of the field
> (emailing the owner when the automated test infrastructure SGI used
> 10 years ago failed) is no longer used...

We should really just kill it.  If anyone runs the test automated again
he should get the mails and/or cc the xfs lists.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/3] xfstests: fix 122 for recent xfsprogs
  2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
  2011-10-11 22:36 ` [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Dave Chinner
@ 2011-10-13 11:06 ` Alex Elder
  2 siblings, 0 replies; 14+ messages in thread
From: Alex Elder @ 2011-10-13 11:06 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Mon, 2011-10-10 at 14:21 -0400, Christoph Hellwig wrote:
> - filter out xfs_alloctype_t, this was an internal emum that got removed
>  - filter out xfs_bmbt_rec_32_t, this is a variant of the xfs_bmbt_rec_t
>    that had almost no users and was removed
>  - filter out xfs_dinode_core_t, the separate dinode core is gone, and just
>    checking the size of the full dinode is enough
>  - accept xfs_bmbt_rec_t as the new canonical name for xfs_bmbt_rec_64_t,
>    and replace the old name with the new one in the output stream.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
  2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
  2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
  2011-10-11 22:40   ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
@ 2011-10-13 11:06   ` Alex Elder
  2 siblings, 0 replies; 14+ messages in thread
From: Alex Elder @ 2011-10-13 11:06 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Mon, 2011-10-10 at 14:22 -0400, Christoph Hellwig wrote:
> This effectively reverts
> 
> 	xfstests: add mapped write fsx operations to 091
> 
> and adds a new test case for it.  It tests something slightly different, and
> regressions in existing tests due to new features are pretty nasty in a
> test suite.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.  I see no need to re-post just to delete
the "author" line.  Do that as a separate commit that
updates all the tests at once.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3 v2] xfstests: allow 091 for non-xfs filesystems
  2011-10-11 14:18     ` [PATCH 3/3 v2] " Christoph Hellwig
  2011-10-11 22:40       ` Dave Chinner
@ 2011-10-13 11:06       ` Alex Elder
  1 sibling, 0 replies; 14+ messages in thread
From: Alex Elder @ 2011-10-13 11:06 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Tue, 2011-10-11 at 10:18 -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
> 
> Also use _supported_os properly instead of erroring out manually on
> IRIX.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks OK to me.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
  2011-10-11 22:40   ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
  2011-10-12  7:32     ` Christoph Hellwig
@ 2011-10-13 11:06     ` Alex Elder
  1 sibling, 0 replies; 14+ messages in thread
From: Alex Elder @ 2011-10-13 11:06 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Christoph Hellwig, xfs

On Wed, 2011-10-12 at 09:40 +1100, Dave Chinner wrote:
> On Mon, Oct 10, 2011 at 02:22:16PM -0400, Christoph Hellwig wrote:
> > This effectively reverts
> > 
> > 	xfstests: add mapped write fsx operations to 091
> > 
> > and adds a new test case for it.  It tests something slightly different, and
> > regressions in existing tests due to new features are pretty nasty in a
> > test suite.
> 
> Makes sense.
> 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > Index: xfstests-dev/263
> > ===================================================================
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ xfstests-dev/263	2011-10-10 18:06:59.000000000 +0000
> > @@ -0,0 +1,64 @@
> > +#! /bin/bash
> > +# FS QA Test No. 263
> > +#
> > +# fsx exercising direct IO vs sub-block buffered I/O
> > +#
> > +#-----------------------------------------------------------------------
> > +# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU General Public License as
> > +# published by the Free Software Foundation.
> > +#
> > +# This program is distributed in the hope that it would be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write the Free Software Foundation,
> > +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> > +#
> > +#-----------------------------------------------------------------------
> > +#
> > +# creator
> > +owner=nathans@sgi.com
> 
> No point keeping an invalid email address as the owner of a new
> test.

My only comment was that there is some small value in
knowing who the original author of the test.

> FWIW, I'm considering removing this from the tests as the
> information is in the commit history, and the use of the field
> (emailing the owner when the automated test infrastructure SGI used
> 10 years ago failed) is no longer used...

...but you're right, it would be in the commit history
so that's probably sufficient.  I have no objection to
deleting it from all the tests (and the template).

					-Alex

> Otherwise looks OK.
> 
> Reviewed-by: Dave Chinner <dchinner@redhat.com>



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2011-10-13 11:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
2011-10-10 18:22   ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
2011-10-11  2:11     ` Dave Chinner
2011-10-11 12:46       ` Christoph Hellwig
2011-10-11 14:18     ` [PATCH 3/3 v2] " Christoph Hellwig
2011-10-11 22:40       ` Dave Chinner
2011-10-13 11:06       ` Alex Elder
2011-10-11 22:40   ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
2011-10-12  7:32     ` Christoph Hellwig
2011-10-13 11:06     ` Alex Elder
2011-10-13 11:06   ` Alex Elder
2011-10-11 22:36 ` [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Dave Chinner
2011-10-13 11:06 ` Alex Elder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox