From: Alex Elder <aelder@sgi.com>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 3/8] xfsdump: implement lock abstraction with pthreads
Date: Mon, 7 Nov 2011 20:02:11 -0600 [thread overview]
Message-ID: <1320717731.3186.89.camel@doink> (raw)
In-Reply-To: <1320699511-12281-4-git-send-email-wkendall@sgi.com>
On Mon, 2011-11-07 at 14:58 -0600, Bill Kendall wrote:
> This patch implements xfsdump's locking abstraction using pthread
> locking primitives. The obsolete IRIX locking code has been removed.
>
> The POSIX semaphore implementation on Linux does not provide a count
> of threads waiting to decrement the semaphore, so qsemPblocked()
> has been removed. It was called from a few asserts, but the current
> count of the semaphore was also checked in adjacent asserts, so
> it was deemed acceptable to remove the qsemPblocked() asserts.
>
> A few debug-level log calls had to be changed to use the "no lock"
> flag to prevent locks from being acquired out of order. This is
> used in various debug messages throughout xfsdump.
>
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
I have not done a very thorough review, but this
looks OK to me.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-08 2:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:58 [PATCH v2 0/8] xfsdump: enable support for multiple streams Bill Kendall
2011-11-07 20:58 ` [PATCH v2 1/8] xfsdump: link with libpthread Bill Kendall
2011-11-08 2:02 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 2/8] xfsdump: remove multi-stream synchronous dir dump Bill Kendall
2011-11-08 2:02 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 3/8] xfsdump: implement lock abstraction with pthreads Bill Kendall
2011-11-08 2:02 ` Alex Elder [this message]
2011-11-07 20:58 ` [PATCH v2 4/8] xfsdump: simplify qlock ordinal bitmap Bill Kendall
2011-11-08 2:02 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 5/8] xfsdump: convert IRIX sproc threads to pthreads Bill Kendall
2011-11-08 2:02 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 6/8] xfsdump: process thread exit status Bill Kendall
2011-11-08 2:03 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 7/8] xfsdump: path lookup cache must be thread specific Bill Kendall
2011-11-08 2:03 ` Alex Elder
2011-11-07 20:58 ` [PATCH v2 8/8] xfsdump: enable multiple streams Bill Kendall
2011-11-08 2:03 ` Alex Elder
2011-11-10 11:00 ` [PATCH v2 0/8] xfsdump: enable support for " Christoph Hellwig
2011-11-10 16:22 ` Bill Kendall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320717731.3186.89.camel@doink \
--to=aelder@sgi.com \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox