[patch] xfsprogs - workaround debian build daemon dependency resolution

[patch] xfsprogs - workaround debian build daemon dependency resolution

[Nathan Scott]

[-- Attachment #1.1: Type: text/plain, Size: 961 bytes --]

Workaround the Debian buildd dependency handling for libreadline5 library
handling

Evidently the buildd daemons process depenencies differently to local
builds, and
expect the first of optional dependencies to be resolved.  Flip the
ordering to match
this dependency.

Signed-off-by: Nathan Scott <nathans@debian.org>


diff --git a/debian/control b/debian/control
index f813a43..89f8c6e 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@ Priority: optional
 Maintainer: XFS Development Team <xfs@oss.sgi.com>
 Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <
anibal@debian.org>
 Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool,
libreadline5-dev | libreadline-gplv2-dev, libblkid-dev (>= 2.17)
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool,
libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17)
 Standards-Version: 3.9.1
 Homepage: http://oss.sgi.com/projects/xfs/

[-- Attachment #1.2: Type: text/html, Size: 1468 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs - workaround debian build daemon dependency resolution

[Alex Elder]

On Tue, 2011-11-15 at 20:39 +1100, Nathan Scott wrote:
> Workaround the Debian buildd dependency handling for libreadline5 library
> handling
> 
> Evidently the buildd daemons process depenencies differently to local
> builds, and
> expect the first of optional dependencies to be resolved.  Flip the
> ordering to match
> this dependency.
> 
> Signed-off-by: Nathan Scott <nathans@debian.org>

Looks fine to me.

Signed-off-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs - workaround debian build daemon dependency resolution

[Alex Elder]

On Thu, 2011-11-17 at 13:28 -0600, Alex Elder wrote:
> On Tue, 2011-11-15 at 20:39 +1100, Nathan Scott wrote:
> > Workaround the Debian buildd dependency handling for libreadline5 library
> > handling
> > 
> > Evidently the buildd daemons process depenencies differently to local
> > builds, and
> > expect the first of optional dependencies to be resolved.  Flip the
> > ordering to match
> > this dependency.
> > 
> > Signed-off-by: Nathan Scott <nathans@debian.org>
> 
> Looks fine to me.
> 
> Signed-off-by: Alex Elder <aelder@sgi.com>
> 

Actually, it *looked* fine superficially, but it's crap.

Get in touch with me or Ben (bpm) on IRC so we can get
this fixed and we'll cut a release with this included
today.

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs - workaround debian build daemon dependency resolution

[Ben Myers]

Hi Nathan,

On Thu, Nov 17, 2011 at 01:42:24PM -0600, Alex Elder wrote:
> On Thu, 2011-11-17 at 13:28 -0600, Alex Elder wrote:
> > On Tue, 2011-11-15 at 20:39 +1100, Nathan Scott wrote:
> > > Workaround the Debian buildd dependency handling for libreadline5 library
> > > handling
> > > 
> > > Evidently the buildd daemons process depenencies differently to local
> > > builds, and
> > > expect the first of optional dependencies to be resolved.  Flip the
> > > ordering to match
> > > this dependency.
> > > 
> > > Signed-off-by: Nathan Scott <nathans@debian.org>
> > 
> > Looks fine to me.
> > 
> > Signed-off-by: Alex Elder <aelder@sgi.com>
> > 
> 
> Actually, it *looked* fine superficially, but it's crap.

Is this what you're after?

diff --git a/debian/control b/debian/control
index f813a43..ca517ad 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <xfs@oss.sgi.com>
 Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline5-dev | libreadline-gplv2-dev, libblkid-dev (>= 2.17)
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17)
 Standards-Version: 3.9.1
 Homepage: http://oss.sgi.com/projects/xfs/



Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs - workaround debian build daemon dependency resolution

[Nathan Scott]

[-- Attachment #1.1: Type: text/plain, Size: 73 bytes --]

Spot on - thanks!  T'was wrong in my workarea ... :(

cheers.

--
Nathan

[-- Attachment #1.2: Type: text/html, Size: 97 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs