From: Ben Myers <bpm@sgi.com>
To: stable@vger.kernel.org, greg@kroah.com
Cc: bpm@sgi.com, Alex Elder <aelder@sgi.com>,
Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>,
xfs@oss.sgi.com
Subject: [PATCH 3/6] xfs: Return -EIO when xfs_vn_getattr() failed
Date: Thu, 1 Dec 2011 17:27:41 -0600 [thread overview]
Message-ID: <1322782064-1723-4-git-send-email-bpm@sgi.com> (raw)
In-Reply-To: <1322782064-1723-1-git-send-email-bpm@sgi.com>
From: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
commit ed32201e65e15f3e6955cb84cbb544b08f81e5a5 upstream.
An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
Currently it returns EIO, not negative value, when it failed. As a
result, the system call returns not negative value even though an
error occured. The stat(2), ls and mv commands cannot handle this
error and do not work correctly.
This patch fixes this bug, and returns -EIO, not EIO when an error
is detected in xfs_vn_getattr().
Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
---
fs/xfs/xfs_iops.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 673704f..474920b 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -465,7 +465,7 @@ xfs_vn_getattr(
trace_xfs_getattr(ip);
if (XFS_FORCED_SHUTDOWN(mp))
- return XFS_ERROR(EIO);
+ return -XFS_ERROR(EIO);
stat->size = XFS_ISIZE(ip);
stat->dev = inode->i_sb->s_dev;
--
1.7.8.rc4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-01 23:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 23:27 [PATCH 0/6] XFS update for 3.1-stable (again) Ben Myers
2011-12-01 23:27 ` [PATCH 1/6] xfs: don't serialise direct IO reads on page cache checks Ben Myers
2011-12-01 23:27 ` [PATCH 2/6] xfs: avoid direct I/O write vs buffered I/O race Ben Myers
2011-12-01 23:27 ` Ben Myers [this message]
2011-12-01 23:27 ` [PATCH 4/6] xfs: fix buffer flushing during unmount Ben Myers
2011-12-01 23:27 ` [PATCH 5/6] xfs: Fix possible memory corruption in xfs_readlink Ben Myers
2011-12-01 23:27 ` [PATCH 6/6] xfs: use doalloc flag in xfs_qm_dqattach_one() Ben Myers
2011-12-01 23:33 ` [PATCH 0/6] XFS update for 3.1-stable (again) Greg KH
2011-12-02 23:12 ` Greg KH
2011-12-06 17:05 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2011-11-28 21:40 [PATCH 0/6] XFS update for 3.1-stable Greg KH
2011-11-30 18:10 ` XFS update for 3.1-stable (resent) Ben Myers
2011-11-30 18:10 ` [PATCH 3/6] xfs: Return -EIO when xfs_vn_getattr() failed Ben Myers
2011-11-23 21:38 [PATCH 0/6] XFS update for 3.1-stable Ben Myers
2011-11-23 21:38 ` [PATCH 3/6] xfs: Return -EIO when xfs_vn_getattr() failed Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322782064-1723-4-git-send-email-bpm@sgi.com \
--to=bpm@sgi.com \
--cc=aelder@sgi.com \
--cc=greg@kroah.com \
--cc=mitsuo.hayasaka.hu@hitachi.com \
--cc=stable@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox