[PATCH 0/2] xfstests: small fixes.

[PATCH 0/2] xfstests: small fixes.

[Dave Chinner]

A couple of simple fixes for test harness failures I'm now
regularly hitting.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 1/2] xfstests: test 110 sometimes fails to unmount scratch dev

[Dave Chinner]

From: Dave Chinner <dchinner@redhat.com>

It runs a bunch of rm processes inteh background, tehn immediately
calls _check_scratch_fs without waiting for them to complete, hence
the unmount can fail with abusy filesystem error.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 110 |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/110 b/110
index cf5f663..aad5835 100755
--- a/110
+++ b/110
@@ -79,6 +79,7 @@ do
     rm $SCRATCH_MNT/test/${STR1}${STR2}${STR3}${I} &
     let I=$I+1
 done
+wait
 
 _check_scratch_fs
 
-- 
1.7.5.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 2/2] xfstests: ln failure output has changed again

[Dave Chinner]

From: Dave Chinner <dchinner@redhat.com>

Recent coreutils packages have changed the failure output of ln(1)
(again!) to be more verbose, breaking the filter in test 103:

-ln: creating symbolic link `SCRATCH_MNT/nosymlink/target' to `SCRATCH_MNT/nosymlink/source': Operation not permitted
+ln: failed to create symbolic link `SCRATCH_MNT/nosymlink/target' to `SCRATCH_MNT/nosymlink/source': Operation not permitted

Fix it.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 103 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/103 b/103
index 1c9994e..e383991 100755
--- a/103
+++ b/103
@@ -57,7 +57,8 @@ _create_scratch()
 _filter_ln()
 {
     sed -e "s,SCRATCH_MNT/nosymlink/target - Operation not permitted,ln: creating symbolic link \`SCRATCH_MNT/nosymlink/target\' to \`SCRATCH_MNT/nosymlink/source\': Operation not permitted,g" \
-        -e "/SCRATCH_MNT.*to.*SCRATCH_MNT/! s,: Operation not permitted, to \`SCRATCH_MNT/nosymlink/source\': Operation not permitted,g"
+        -e "/SCRATCH_MNT.*to.*SCRATCH_MNT/! s,: Operation not permitted, to \`SCRATCH_MNT/nosymlink/source\': Operation not permitted,g" \
+	-e "s,failed to create,creating,"
 }
 
 _filter_noymlinks_flag()
-- 
1.7.5.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 1/2] xfstests: test 110 sometimes fails to unmount scratch dev

[Christoph Hellwig]

On Tue, Dec 06, 2011 at 10:16:58PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> It runs a bunch of rm processes inteh background, tehn immediately
> calls _check_scratch_fs without waiting for them to complete, hence
> the unmount can fail with abusy filesystem error.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 2/2] xfstests: ln failure output has changed again

[Christoph Hellwig]

On Tue, Dec 06, 2011 at 10:16:59PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Recent coreutils packages have changed the failure output of ln(1)
> (again!) to be more verbose, breaking the filter in test 103:

Great..

> 
> -ln: creating symbolic link `SCRATCH_MNT/nosymlink/target' to `SCRATCH_MNT/nosymlink/source': Operation not permitted
> +ln: failed to create symbolic link `SCRATCH_MNT/nosymlink/target' to `SCRATCH_MNT/nosymlink/source': Operation not permitted
> 
> Fix it.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs