From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:33256 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfDXFVp (ORCPT ); Wed, 24 Apr 2019 01:21:45 -0400 Date: Wed, 24 Apr 2019 01:21:44 -0400 (EDT) From: Pankaj Gupta Message-ID: <1325148804.23168491.1556083304080.JavaMail.zimbra@redhat.com> In-Reply-To: <20190423142748.GE9910@quack2.suse.cz> References: <20190423080612.15361-1-pagupta@redhat.com> <20190423080612.15361-6-pagupta@redhat.com> <20190423142748.GE9910@quack2.suse.cz> Subject: Re: [Qemu-devel] [PATCH v6 5/6] ext4: disable map_sync for async flush MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jan Kara Cc: cohuck@redhat.com, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, dave jiang , linux-nvdimm@lists.01.org, vishal l verma , david@redhat.com, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, pbonzini@redhat.com, dan j williams , lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, imammedo@redhat.com > > On Tue 23-04-19 13:36:11, Pankaj Gupta wrote: > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > > with asynchronous dax_device. Virtio pmem provides > > asynchronous host page cache flush mechanism. We don't > > support 'MAP_SYNC' with virtio pmem and ext4. > > > > Signed-off-by: Pankaj Gupta > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara Thank you. Will add this. Best regards, Pankaj > > Honza > > > > --- > > fs/ext4/file.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > > index 69d65d49837b..4b2ccaf1932e 100644 > > --- a/fs/ext4/file.c > > +++ b/fs/ext4/file.c > > @@ -360,15 +360,16 @@ static const struct vm_operations_struct > > ext4_file_vm_ops = { > > static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) > > { > > struct inode *inode = file->f_mapping->host; > > + struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); > > + struct dax_device *dax_dev = sbi->s_daxdev; > > > > - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) > > + if (unlikely(ext4_forced_shutdown(sbi))) > > return -EIO; > > > > - /* > > - * We don't support synchronous mappings for non-DAX files. At least > > - * until someone comes with a sensible use case. > > + /* We don't support synchronous mappings for non-DAX files and > > + * for DAX files if underneath dax_device is not synchronous. > > */ > > - if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC)) > > + if (!daxdev_mapping_supported(vma, dax_dev)) > > return -EOPNOTSUPP; > > > > file_accessed(file); > > -- > > 2.20.1 > > > -- > Jan Kara > SUSE Labs, CR > >