From: Bill Kendall <wkendall@sgi.com>
To: xfs@oss.sgi.com
Subject: [PATCH] xfsdump: fix restore of ext attrs on root directory
Date: Fri, 6 Jan 2012 14:51:56 -0600 [thread overview]
Message-ID: <1325883116-21990-1-git-send-email-wkendall@sgi.com> (raw)
xfsrestore fails to restore extended attributes on the root directory
because Node2path(), which returns a pathname relative to the restore
root, returns an empty string instead of ".".
Signed-off-by: Bill Kendall <wkendall@sgi.com>
---
restore/tree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/restore/tree.c b/restore/tree.c
index afe7042..bb5df06 100644
--- a/restore/tree.c
+++ b/restore/tree.c
@@ -3450,7 +3450,7 @@ static bool_t
Node2path( nh_t nh, char *path, char *errmsg )
{
intgen_t remainingcnt;
- path[ 0 ] = 0; /* in case root node passed in */
+ strcpy(path, "."); /* in case root node passed in */
remainingcnt = Node2path_recurse( nh, path, MAXPATHLEN, 0 );
if ( remainingcnt <= 0 ) {
node_t *np = Node_map( nh );
--
1.7.0.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-01-06 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 20:51 Bill Kendall [this message]
2012-01-11 11:42 ` [PATCH] xfsdump: fix restore of ext attrs on root directory Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325883116-21990-1-git-send-email-wkendall@sgi.com \
--to=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox