Re: [PATCH 01/10] xfs: clean up minor sparse warnings

Dave Chinner
2012-03-09T00:30:14Z

On Thu, Mar 08, 2012 at 03:34:10PM -0600, Ben Myers wrote:
> On Wed, Mar 07, 2012 at 03:50:19PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Ben Myers <bpm@sgi.com>
>
> ...
>
> > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> > index ab30253..2601d6b 100644
> > --- a/fs/xfs/xfs_iops.c
> > +++ b/fs/xfs/xfs_iops.c
> > @@ -103,12 +103,15 @@ xfs_mark_inode_dirty(
> > }
> >
> >
> > -int xfs_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> > - void *fs_info)
> > +static int
> > +xfs_initxattrs(
> > + struct inode *inode,
> > + const struct xattr *xattr_array,
> > + void *fs_info)
> > {
> > - const struct xattr *xattr;
> > - struct xfs_inode *ip = XFS_I(inode);
> > - int error = 0;
> > + const struct xattr *xattr;
> > + struct xfs_inode *ip = XFS_I(inode);
> > + int error = 0;
>
> I didn't see a sparse warning which this fixes... FWICS all you've done
> here is make it static and fix the formatting.

If fixes this warning:

fs/xfs/xfs_iops.c:106:5: warning: symbol 'xfs_initxattrs' was not declared. Should it be static?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com