Re: [PATCH 01/10] xfs: clean up minor sparse warnings

Ben Myers
2012-03-08T21:34:03Z

On Wed, Mar 07, 2012 at 03:50:19PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Ben Myers <bpm@sgi.com>

...

> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index ab30253..2601d6b 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -103,12 +103,15 @@ xfs_mark_inode_dirty(
> }
>
>
> -int xfs_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int
> +xfs_initxattrs(
> + struct inode *inode,
> + const struct xattr *xattr_array,
> + void *fs_info)
> {
> - const struct xattr *xattr;
> - struct xfs_inode *ip = XFS_I(inode);
> - int error = 0;
> + const struct xattr *xattr;
> + struct xfs_inode *ip = XFS_I(inode);
> + int error = 0;

I didn't see a sparse warning which this fixes... FWICS all you've done
here is make it static and fix the formatting.

This still looks good.. ;)