Re: [PATCH 7/8] xfs: use blocks for storing the desired IO size

Mark Tinguely
2012-03-30T19:13:36Z

On 03/29/12 07:23, Dave Chinner wrote:
> Now that we pass block counts everywhere, and index buffers by block
> number and length in units of blocks, convert the desired IO size
> into block counts rather than bytes. Convert the code to use block
> counts, and those that need byte counts get converted at the time of
> use.
>
> Rename the b_desired_count variable to something closer to it's
> purpose - b_io_length - as it is only used to specify the length of
> an IO for a subset of the buffer. The only time this is used is for
> log IO - both writing iclogs and during log recovery. In all other
> cases, the b_io_length matches b_length, and hence a lot of code
> confuses the two. e.g. the buf item code uses the io count
> exclusively when it should be using the buffer length. Fix these
> apprpriately as they are found.
>
> Also, remove the XFS_BUF_{SET_}COUNT() macros that are just wrappers
> around the desired IO length. They only serve to make the code
> shouty loud, don't actually add any real value, and are often used
> incorrectly.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig<hch@lst.de>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>