Re: [PATCH 8/8] xfs: kill xfs_buf_btoc

Mark Tinguely
2012-03-30T19:14:00Z

On 03/29/12 07:23, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> xfs_buf_btoc and friends are simple macros that do basic block
> to page index conversion and vice versa. These aren't widely used,
> and we use open coded masking and shifting everywhere else. Hence
> remove themacros and open code the work they do.
>
> Also, use of PAGE_CACHE_{SIZE|SHIFT|MASK} for these macros is now
> incorrect - we are using pages directly and not the page cache, so
> use PAGE_{SIZE|MASK|SHIFT} instead.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>