public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Marek <tmarek@redhat.com>
To: xfs@oss.sgi.com
Cc: Tom Marek <tmarek@redhat.com>, lczerner@redhat.com, dchinner@redhat.com
Subject: [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-sparse2
Date: Tue, 17 Apr 2012 11:24:46 +0200	[thread overview]
Message-ID: <1334654687-25450-2-git-send-email-tmarek@redhat.com> (raw)
In-Reply-To: <1334654687-25450-1-git-send-email-tmarek@redhat.com>

Tests number 198 and 240 could fail when aiodio-sparse2 was not build.
_require_aiodio helper was added to common.rc file to fix this.

Cc: david@fromorbit.com
Signed-off-by: Tom Marek <tmarek@redhat.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
---
V2: check for aiodio-sparse2 was moved to helper function located in
    common.rc file. _require_aiodio was added to tests 198 and 240.
 198       |    2 ++
 240       |    1 +
 common.rc |    8 ++++++++
 3 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/198 b/198
index e46ec8d..210b7bb 100755
--- a/198
+++ b/198
@@ -45,6 +45,8 @@ _cleanup()
 _supported_fs generic
 _supported_os Linux
 
+_require_aiodio
+
 echo "Silence is golden."
 
 # real QA test starts here
diff --git a/240 b/240
index 563449e..5b37bdc 100755
--- a/240
+++ b/240
@@ -52,6 +52,7 @@ _supported_fs generic
 _supported_os Linux
 
 _require_sparse_files
+_require_aiodio
 
 echo "Silence is golden."
 
diff --git a/common.rc b/common.rc
index cab0b64..7745df1 100644
--- a/common.rc
+++ b/common.rc
@@ -770,6 +770,14 @@ _require_scratch()
     fi
 }
 
+# this test needs aio-dio-regress to be built
+#
+_require_aiodio()
+{
+    [ -x $here/src/aio-dio-regress/aiodio_sparse2 ] || \
+        _notrun "This tests requires src/aio-dio-regress/ to be built"
+}
+
 # this test needs a logdev
 #
 _require_logdev()
-- 
1.7.7.6

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-04-17  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  9:24 [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress Tom Marek
2012-04-17  9:24 ` Tom Marek [this message]
2012-04-18 23:51   ` [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-sparse2 Dave Chinner
2012-04-19  8:32     ` Lukas Czerner
2012-04-19 13:53       ` Tom Marek
2012-04-17  9:24 ` [PATCH 3/3 V2] xfstests 273: fix of reading scratch size and removing lost+found Tom Marek
2012-04-19  0:01 ` [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress Dave Chinner
2012-04-19  8:37   ` Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334654687-25450-2-git-send-email-tmarek@redhat.com \
    --to=tmarek@redhat.com \
    --cc=dchinner@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox