From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q4LInpXa244374 for ; Mon, 21 May 2012 13:49:51 -0500 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id svBMTYVXVBGXi3JW for ; Mon, 21 May 2012 11:49:50 -0700 (PDT) Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4LInna9007799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 May 2012 14:49:49 -0400 From: Brian Foster Subject: [RFC PATCH v2 0/3] xfs: fix xfsaild races and re-enable idle mode Date: Mon, 21 May 2012 14:49:26 -0400 Message-Id: <1337626169-21730-1-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: Brian Foster Hi all, We reproduced and debugged several hangs in a rhel6.3 kernel that happened to still support xfsaild idle mode. Our short term fix was to disable idle mode as in upstream, but I'd like to fire out a couple potential fixes that allow us to re-enable idle mode, assuming there aren't any other problems I'm not aware of. The details of the bug are at: https://bugzilla.redhat.com/show_bug.cgi?id=813137 ... but I'll try to provide all relevant data in this post. The reproducer is xfstests 273 running in a 100-iteration loop. I have reproduced this hang on upstream kernels quite reliably with commit 670ce93f reverted. The performance enhancement in that commit makes this much harder to reproduce. With the proposed modifications, I've probably run 5+ 100-loop iterations of test 273 without reproducing a hang. Previously, I was able to reproduce the first hang with 100% reliability and the second hang reproduced 10 minutes or so after starting a second 100-loop test (with the first fix applied). I still have to run a full xfstests but the changes are small enough that I wanted to send them out before I got too far. Thanks. Changes since v1: - Rebased against a pristine tree. Brian Foster (3): xfs: re-enable xfsaild idle mode xfs: fix xfsaild hang due to premature idle xfs: fix xfsaild hang due to lost wake ups fs/xfs/xfs_trans_ail.c | 8 ++++---- fs/xfs/xfs_trans_priv.h | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) -- 1.7.7.6 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs