Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents

Christoph Hellwig
2012-06-26T10:16:44Z

On Fri, Jun 22, 2012 at 06:50:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to
> follow due to the readahead and all the context is carries. it is also badly
> indented and so difficult to read. Factor it out into a separate function to
> make it easier to understand and optimise in future patches.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,