Re: [PATCH 08/10] xfstests: enable large fs testing on ext4

Rich Johnston
2012-09-05T16:26:08Z

On 07/26/2012 03:39 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Now that setting up large filesystem testing on sparse loopback
> devices uses a generic method for filling the filesystem, extent
> support to ext4 filesystems.
>
> ext4 is slightly more complex to fill as it does not support files
> larger than 16TB. Hence a slightly more complex method of using
> multiple smaller files to fill the space is necessary.
>
> WARNING: be prepeared for ext4 to take forever to prepare large
> filesystems as allocation of large amounts of space (especially as
> it approaches ENOSPC) is can take minutes rather than milliseconds
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> common.rc | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 90 insertions(+)
>

Looks good.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

Regards
--Rich