Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level

Mark Tinguely
2012-08-15T17:23:08Z

On 08/14/12 16:39, Dave Chinner wrote:
> Ping?
>
> On Thu, Jul 26, 2012 at 07:27:54PM +1000, Dave Chinner wrote:
>> Alt-Subject: Games with Sed, Grep and Awk.
>>
>> This series is based on top of the large filesystem test series.
>>
>> This moves all the tests into a ./tests subdirectory, and sorts them into
>> classes of related tests. Those are:
>>
>> tests/generic: valid for all filesystems
>> tests/shared: valid for a limited number of filesystems
>> tests/xfs: xfs specific tests
>> tests/btrfs btrfs specific tests
>> tests/ext4 ext4 specific tests
>> tests/udf udf specific tests
>>
>> Each directory has it's own group file to determine what groups the
>> tests are associated with. Tests are run in exactly the same was as
>> before, but when trying to run individual tests you need to specify
>> the class as well. e.g. the old way:
>>
>> # ./check 001
>>
>> The new way:
>>
>> # ./check generic/001

I applied the series and started a closer look. I like what you have done.

As far as RFC, the only concern that I have heard so far is the desire
to see benchmarking in the test suite.

--Mark.