Re: [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update

Mark Tinguely
2012-09-19T13:13:36Z

On 09/18/12 18:50, Dave Chinner wrote:
> On Tue, Sep 18, 2012 at 08:59:04AM -0500, Mark Tinguely wrote:
>> This looks great. Like I said earlier, I did not find Brian Foster's
>> log patch:
>> xfs: check for stale inode before acquiring iflock on push
>> Upstream commit: 9a3a5dab63461b84213052888bf38a962b22d035
>> sample implementation listed on:
>> http://oss.sgi.com/archives/xfs/2012-09/msg00188.html
>>
>> Reviewed-by: Mark Tinguely<tinguely@sgi.com>
>
> Thatnks for looking over this, Mark.
>
> The above patch does not directly apply to the 3.0.x branch because
> the rework of the log item lock/push logic in the AIL was not
> included in the series. Hence I'm not sure that backportingthis
> patch is necessary because the problem only arose after we change
> the locking/push logic...
>
> Cheers,
>
> Dave.

Hi Dave.

The original problem was in Linux 2.6.X.

The patch in the above link is a 3.0.42 port of Brian's top of tree
patch. This version places the tests in AIL trylock routine. We have
been using it on Linux 3.0.x for a couple months and it has avoided
the hangs that we used to get before.

Thank-you again for the work.

--Mark T.