Re: [PATCH 02/13] xfs: rename the xfs_syncd workqueue

Dave Chinner
2012-09-03T03:09:11Z

On Sat, Sep 01, 2012 at 07:17:22PM -0400, Christoph Hellwig wrote:
> On Thu, Aug 30, 2012 at 10:00:06PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > There is nothing "sync" realted to this work queue any more. It is a general
> > purpose per-filesystem work queue. Rename it appropriately, and remove the
> > "syncd" naming from various functions.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> With the current leight-weight workqueues I don't see why we'd even want
> a shared one for the different callers. Let's move the patch until
> after killing xfs_flush_worker & co, and then add a workqueue for
> background and the log sync individually.

OK. It starts to make workqueues like slab caches - all the cool
kids have got one. :)

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com