Re: [PATCH 03/13] xfs: rationalise xfs_mount_wq users

Mark Tinguely
2012-09-11T21:24:46Z

On 08/30/12 07:00, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Instead of starting and stopping background work on the xfs_mount_wq
> all at the same time, separate them to where they really are needed
> to start and stop.
>
> The xfs_sync_worker, only needs to be started after all the mount
> processing has completed successfully, while it needs to be stopped
> before the log is unmounted.
>
> The xfs_reclaim_worker is started on demand, and can be
> stopped before the unmount process does it's own inode reclaim pass.
>
> The xfs_flush_inodes work is run on demand, and so we really only
> need to ensure that it has stopped running before we start
> processing an unmount, freeze or remount,ro.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

The patch itself looks good. and the "atomic_read(&bp->b_hold)> 0"
assert appears specific to my machines, so forgive the noise.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>