Re: [PATCH 06/13] xfs: xfs_sync_data is redundant.

Christoph Hellwig
2012-09-28T12:33:24Z

> /*
> + * Flush all dirty data to disk. Must not be called while holding an XFS_ILOCK

slightly too long line.

> + * or a page lock.
> + */
> +static inline void
> +xfs_flush_inodes(struct xfs_inode *ip)
> +{
> + writeback_inodes_sb_if_idle(VFS_I(ip)->i_sb, WB_REASON_FS_FREE_SPACE);
> +}

Passing an inode here seems very odd, an xfs_mount would be the proper
interface.

Looks fine modulo these cosmetic changes, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>