Re: [PATCH 06/13] xfs: xfs_sync_data is redundant.

Brian Foster
2012-10-02T18:57:15Z

On 10/01/2012 08:44 PM, Brian Foster wrote:
> On 10/01/2012 08:10 PM, Dave Chinner wrote:
...
>
> I gave this a quick couple runs against 273 and it passes (on top of
> the entire die-xfssyncd-die patchset). I'll kick off another full run
> on this box overnight. Thanks!
>

And I spoke a bit too soon... I hit the following warning with this change:

WARNING: at fs/fs-writeback.c:1401 sync_inodes_sb+0xc0/0xd0()

The inline patch addresses it. I also see the following message during
273 but it doesn't appear related to this set:

kernel: XFS (dm-4): xlog_verify_grant_tail: space > BBTOB(tail_blocks)

Brian

diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index da69c18..f11133b 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -294,7 +294,9 @@ xfs_new_eof(struct xfs_inode *ip, xfs_fsize_t new_size)
static inline void
xfs_flush_inodes(struct xfs_inode *ip)
{
- writeback_inodes_sb_if_idle(VFS_I(ip)->i_sb, WB_REASON_FS_FREE_SPACE);
+ down_read(&VFS_I(ip)->i_sb->s_umount);
+ sync_inodes_sb(VFS_I(ip)->i_sb);
+ up_read(&VFS_I(ip)->i_sb->s_umount);
}

/*

> Brian
>
>> Cheers,
>>
>> Dave.
>>
>
> _______________________________________________ xfs mailing list
> xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs