Re: [PATCH 07/13] xfs: syncd workqueue is no more

Mark Tinguely
2012-09-28T18:15:59Z

On 09/27/12 23:44, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> With the syncd functions moved to the log and/or removed, the syncd
> workqueue is the only remaining bit left. It is used by the log
> covering/ail pushing work, as well as by the inode reclaim work.
>
> Given how cheap workqueues are these days, give the log and inode
> reclaim work their own work queues and kill the syncd work queue.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

<deleted info>

> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index fed1eb2..65cf42c 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -776,8 +776,23 @@ xfs_init_mount_workqueues(
> WQ_MEM_RECLAIM, 0, mp->m_fsname);
> if (!mp->m_cil_workqueue)
> goto out_destroy_unwritten;
> +
> + mp->m_reclaim_workqueue = alloc_workqueue("xfs-reclaim/%s",
> + WQ_NON_REENTRANT, 0, mp->m_fsname);
> + if (!mp->m_reclaim_workqueue)
> + goto out_destroy_cil;
> +
> + mp->m_log_workqueue = alloc_workqueue("xfs-reclaim/%s",
> + WQ_NON_REENTRANT, 0, mp->m_fsname);

Cut/paste error for the worker name?

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>