From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/2] xfs: fix AGF/alloc workqueue deadlock.
Date: Fri, 5 Oct 2012 11:06:57 +1000 [thread overview]
Message-ID: <1349399219-13024-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
This is a followup from the last conversation with Mark about this
deadlock. I haven't heard anything in the last coupl eof days, so I
figured I'd just write the patches that did what I thought is
needed.
Basically, the stack switch is only needed for userdata in the
delayed allocation path, and nowhere else at this point in time. To
make it so we switch stacks only at this point in time, I introduced
a flag to pass to xfs_bmapi_write(). This means we don't switch
stacks during direct IO, unwritten extent conversion or
preallocation via fallocate/XFS_IOC_RESVSP.
I then moved the stack switch to xfs_bmapi_allocate(), which is
where allocation happens. All the allocation calls within a single
userdata extent allocation occur in this function (both data extent
and bmap btree blocks), so switching stacks here will ensure that
only mapping calls that require allocation will have the stack
switched.
Comments welcome...
Cheers,
Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-10-05 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 1:06 Dave Chinner [this message]
2012-10-05 1:06 ` [PATCH 1/2] xfs: introduce XFS_BMAPI_STACK_SWITCH Dave Chinner
2012-10-05 13:27 ` Mark Tinguely
2012-10-05 1:06 ` [PATCH 2/2] xfs: move allocation stack switch up to xfs_bmapi_allocate Dave Chinner
2012-10-05 13:28 ` Mark Tinguely
2012-10-18 22:51 ` [PATCH 0/2] xfs: fix AGF/alloc workqueue deadlock Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349399219-13024-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox