Re: [PATCH 08/19] xfs: verify inode buffers as they are read from disk

Christoph Hellwig
2012-10-11T21:44:25Z

> + if (unlikely(XFS_TEST_ERROR(!di_ok, mp,
> + XFS_ERRTAG_ITOBP_INOTOBP,
> + XFS_RANDOM_ITOBP_INOTOBP))) {
> + xfs_buf_ioerror(bp, EFSCORRUPTED);
> + XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,
> + mp, dip);
> +#ifdef DEBUG
> + xfs_emerg(mp,
> + "bad inode magic/vsn daddr %lld #%d (magic=%x)",
> + (unsigned long long)bp->b_bn, i,
> + be16_to_cpu(dip->di_magic));
> + ASSERT(0);
> +#endif

Is there any point in having this additional output in addition to the
high error level corruption report above?