Re: [PATCH v7 07/10] xfs: add inode id filtering to eofblocks scan

Dave Chinner
2012-11-07T20:31:38Z

On Wed, Nov 07, 2012 at 12:21:13PM -0500, Brian Foster wrote:
> Support inode ID filtering in the eofblocks scan. The caller must
> set the associated XFS_EOF_FLAGS_*ID bit and ID field.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
> ---
>
> v7:
> - Separate padding into two fields to explicitly handle alignment requirements.
> - Fix up style of flags defines.
>
> fs/xfs/xfs_fs.h | 14 ++++++++++++--
> fs/xfs/xfs_icache.c | 22 ++++++++++++++++++++++
> fs/xfs/xfs_ioctl.c | 3 ++-
> 3 files changed, 36 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h
> index 26ff43a..7113564 100644
> --- a/fs/xfs/xfs_fs.h
> +++ b/fs/xfs/xfs_fs.h
> @@ -345,13 +345,23 @@ typedef struct xfs_error_injection {
> struct xfs_eofblocks {
> __u32 eof_version;
> __u32 eof_flags;
> - __u64 pad[15];
> + uid_t eof_uid;
> + gid_t eof_gid;
> + prid_t eof_prid;
> + __u32 pad32;
> + __u64 pad64[13];
> };

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com