Re: [PATCH v6 07/10] xfs: add inode id filtering to eofblocks scan

Mark Tinguely
2012-11-06T16:39:21Z

On 11/06/12 08:50, Brian Foster wrote:
> Support inode ID filtering in the eofblocks scan. The caller must
> set the associated XFS_EOF_FLAGS_*ID bit and ID field.
>
> Signed-off-by: Brian Foster<bfoster@redhat.com>
> ---

turn 0;
>
> + if (eofb&&

vvvvvvv
> + (eofb->eof_flags& (XFS_EOF_FLAGS_UID|XFS_EOF_FLAGS_GID|
> + XFS_EOF_FLAGS_PRID))&&
^^^^^^
Not a big deal but wouldn't xfs_inode_match_id() also check these flags?

> + !xfs_inode_match_id(ip, eofb))
> + return 0;
> +

Consider this

Reviewed-by: Mark Tinguely <tinguely@sgi.com>