Re: [PATCH 4/4] xfs: fix sparse reported log CRC endian issue

Christoph Hellwig
2012-11-28T13:28:43Z

On Wed, Nov 28, 2012 at 01:01:03PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Not a bug as such, just warning noise from the xlog_cksum()
> returning a __be32 type when it shoul dbe returning a __le32 type.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

The patch look okay.

But why are we storing the crc field little endian while all other on
disk formats are big endian? (And yes I realize it might as well have
been me who did that back in the idea, but I still have no idea why)