[RFC] mm: change invalidatepage prototype to accept length

Lukas Czerner
2013-02-01T10:43:54Z

Hi,

This set of patches are aimed to allow truncate_inode_pages_range() handle
ranges which are not aligned at the end of the page. Currently it will
hit BUG_ON() when the end of the range is not aligned. Punch hole feature
however can benefit from this ability saving file systems some work not
forcing them to implement their own invalidate code to handle unaligned
ranges.

In order for this to woke we need change ->invalidatepage() address space
operation to to accept range to invalidate by adding 'length' argument in
addition to 'offset'. This is different from my previous attempt to create
new aop ->invalidatepage_range (http://lwn.net/Articles/514828/) which I
reconsidered to ne unnecessary.

For description purposes this patch set can be divided into following
groups:

patch 0001: Change ->invalidatepage() prototype adding 'length' argument
and changing all the instances. In very simple cases file
system methods are completely adapted, otherwise only
prototype is changed and the rest will follow. This patch
also implement the 'range' invalidation in
block_invalidatepage().

patch 0002 - 0009:
Make the use of new 'length' argument in the file system
itself. Some file systems can take advantage of it trying
to invalidate only portion of the page if possible, some
can't, however none of the file systems currently attempt
to truncate non page aligned ranges.

patch 0010: Teach truncate_inode_pages_range() to handle non page aligned
ranges.

patch 0012 - 0018:
Ext4 changes build on top of previous changes, simplifying
punch hole code. Not all changes are realated specifically
to invalidatepage() change, but all are related to the punch
hole feature.

Even though this patch set would mainly affect functionality of the file
file systems implementing punch hole I've tested all the following file
system using xfstests without noticing any bugs related to this change.

ext3, ext4, xfs, btrfs, gfs2 and reiserfs

the much smaller changes in other file systems has not been directly tested,
so please review.

Thanks!
-Lukas

--

Documentation/filesystems/Locking | 6 +-
Documentation/filesystems/vfs.txt | 20 ++--
fs/9p/vfs_addr.c | 5 +-
fs/afs/file.c | 10 +-
fs/btrfs/disk-io.c | 3 +-
fs/btrfs/extent_io.c | 2 +-
fs/btrfs/inode.c | 3 +-
fs/buffer.c | 21 ++-
fs/ceph/addr.c | 15 +-
fs/cifs/file.c | 5 +-
fs/exofs/inode.c | 6 +-
fs/ext3/inode.c | 9 +-
fs/ext4/ext4.h | 14 +-
fs/ext4/extents.c | 188 ++++++++--------------
fs/ext4/indirect.c | 13 +--
fs/ext4/inode.c | 320 ++++++++++++++++--------------------
fs/f2fs/data.c | 3 +-
fs/f2fs/node.c | 3 +-
fs/gfs2/aops.c | 17 ++-
fs/jbd/transaction.c | 19 ++-
fs/jbd2/transaction.c | 24 ++-
fs/jfs/jfs_metapage.c | 5 +-
fs/logfs/file.c | 3 +-
fs/logfs/segment.c | 3 +-
fs/nfs/file.c | 8 +-
fs/ntfs/aops.c | 2 +-
fs/ocfs2/aops.c | 5 +-
fs/reiserfs/inode.c | 12 +-
fs/ubifs/file.c | 5 +-
fs/xfs/xfs_aops.c | 10 +-
fs/xfs/xfs_trace.h | 41 +++++-
include/linux/buffer_head.h | 3 +-
include/linux/fs.h | 2 +-
include/linux/jbd.h | 2 +-
include/linux/jbd2.h | 2 +-
include/linux/mm.h | 3 +-
include/trace/events/ext3.h | 12 +-
include/trace/events/ext4.h | 64 +++++---
mm/readahead.c | 2 +-
mm/truncate.c | 86 ++++++----
40 files changed, 511 insertions(+), 465 deletions(-)

[PATCH 01/18] mm: change invalidatepage prototype to accept length
[PATCH 02/18] jbd2: change jbd2_journal_invalidatepage to accept
[PATCH 03/18] ext4: use ->invalidatepage() length argument
[PATCH 04/18] jbd: change journal_invalidatepage() to accept length
[PATCH 05/18] xfs: use ->invalidatepage() length argument
[PATCH 06/18] ocfs2: use ->invalidatepage() length argument
[PATCH 07/18] ceph: use ->invalidatepage() length argument
[PATCH 08/18] gfs2: use ->invalidatepage() length argument
[PATCH 09/18] reiserfs: use ->invalidatepage() length argument
[PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non
[PATCH 11/18] Revert "ext4: remove no longer used functions in
[PATCH 12/18] Revert "ext4: fix fsx truncate failure"
[PATCH 13/18] ext4: use ext4_zero_partial_blocks in punch_hole
[PATCH 14/18] ext4: remove unused discard_partial_page_buffers
[PATCH 15/18] ext4: remove unused code from ext4_remove_blocks()
[PATCH 16/18] ext4: update ext4_ext_remove_space trace point
[PATCH 17/18] ext4: make punch hole code path work with bigalloc
[PATCH 18/18] ext4: Allow punch hole with bigalloc enabled