public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 24/25] xfstests: clean up test 262 output file use.
Date: Fri, 15 Mar 2013 23:28:08 +1100	[thread overview]
Message-ID: <1363350489-22257-25-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1363350489-22257-1-git-send-email-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

Test 262 uses ${} notation for some variables, and so is resistant
to grep and sed matches. Change it to use the same notation as the
rest of xfstests and fix up the output file redirections made in
previous patches.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/262 |   36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/tests/xfs/262 b/tests/xfs/262
index 01f7f8b..0c15787 100755
--- a/tests/xfs/262
+++ b/tests/xfs/262
@@ -28,15 +28,15 @@
 
 seq=$(basename $0)
 seqres=$RESULT_DIR/$seq
-echo "QA output created by ${seq}"
+echo "QA output created by $seq"
 
 here=$(pwd)
 
-cp /dev/null "${seq}.full"
+rm -f $seqres.full
 
 tmp=/tmp/$$
-my_projects=${tmp}.projects
-my_projid=${tmp}.projid
+my_projects=$tmp.projects
+my_projid=$tmp.projid
 proj_name=test_project
 proj_num=1
 
@@ -48,7 +48,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _cleanup()
 {
     cd /
-    rm -f ${tmp}.*
+    rm -f $tmp.*
 }
 
 # get standard environment, filters and checks
@@ -60,7 +60,7 @@ echo "Silence is golden."
 
 # real QA test starts here
 
-proj_dir="${SCRATCH_MNT}/test"
+proj_dir="$SCRATCH_MNT/test"
 
 # Modify as appropriate.
 _supported_fs xfs
@@ -108,38 +108,38 @@ _filter_quota_rpt() {
 }
 
 _quota_cmd() {
-	xfs_quota -P "${my_projid}" -D "${my_projects}" -x \
-		-c "$@" "${SCRATCH_MNT}"
+	xfs_quota -P "$my_projid" -D "$my_projects" -x \
+		-c "$@" "$SCRATCH_MNT"
 }
 
 # Set up--mount scratch and create the project directory
 
-echo ${proj_name}:${proj_num} > "${my_projid}"
-echo ${proj_num}:${proj_dir} > "${my_projects}"
+echo $proj_name:$proj_num > "$my_projid"
+echo $proj_num:$proj_dir > "$my_projects"
 
-_scratch_mkfs						>> "${seq}.full" 2>&1
+_scratch_mkfs						>> "$seqres.full" 2>&1
 
 export MOUNT_OPTIONS="-opquota"
 _qmount
 mkdir -p "${proj_dir}"
 
 # Setup the project quota directory
-_quota_cmd "project -s ${proj_name}"			>> "${seq}.full" 2>&1
+_quota_cmd "project -s ${proj_name}"			>> "$seqres.full" 2>&1
 
 # Assign block quota limits
 _quota_cmd "limit -p bhard=${qlimit_meg}m bsoft=${qlimit_meg}m ${proj_name}" \
-							2>> "${seq}.full" 1>&2
+							2>> "$seqres.full" 1>&2
 
 # See what gets reported
-_quota_cmd "report"		| _filter_quota_rpt	2>> "${seq}.full"
-_quota_cmd "df"			| _filter_quota_rpt	2>> "${seq}.full"
+_quota_cmd "report"		| _filter_quota_rpt	2>> "$seqres.full"
+_quota_cmd "df"			| _filter_quota_rpt	2>> "$seqres.full"
 
 # This time using "human readable" output
-_quota_cmd "report -h"		| _filter_quota_rpt	2>> "${seq}.full"
-_quota_cmd "df -h"		| _filter_quota_rpt	2>> "${seq}.full"
+_quota_cmd "report -h"		| _filter_quota_rpt	2>> "$seqres.full"
+_quota_cmd "df -h"		| _filter_quota_rpt	2>> "$seqres.full"
 
 # Clean up
-rm -rf "${proj_dir}"
+rm -rf "$proj_dir"
 _scratch_unmount
 
 status=0	# success, all done
-- 
1.7.10.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-03-15 12:28 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 12:27 [PATCH 00/25] xfstests: xfstests: move tests out of top level Dave Chinner
2013-03-15 12:27 ` [PATCH 01/25] xfstests: remove remake script Dave Chinner
2013-03-22 16:51   ` Phil White
2013-03-15 12:27 ` [PATCH 02/25] xfstests: remove bench infrastructure Dave Chinner
2013-03-15 19:36   ` Phil White
2013-03-19 22:31     ` Dave Chinner
2013-03-21 23:52       ` Phil White
2013-03-22  7:37         ` Dave Chinner
2013-03-22 16:22           ` Troy McCorkell
2013-03-26 20:26             ` Troy McCorkell
2013-03-22 16:53   ` Phil White
2013-03-15 12:27 ` [PATCH 03/25] xfstests: kill useless test owner fields Dave Chinner
2013-03-22 16:57   ` Phil White
2013-03-15 12:27 ` [PATCH 04/25] xfstests: remove stale machine configs Dave Chinner
2013-03-22 17:02   ` Phil White
2013-03-15 12:27 ` [PATCH 05/25] xfstests: fold common into check Dave Chinner
2013-03-23 10:18   ` Phil White
2013-03-15 12:27 ` [PATCH 06/25] xfstests: clean up and simply check CLI option parsing Dave Chinner
2013-03-23 10:19   ` Phil White
2013-03-15 12:27 ` [PATCH 07/25] xfstests: kill hangcheck stuff from check Dave Chinner
2013-03-23 10:19   ` Phil White
2013-03-15 12:27 ` [PATCH 08/25] xfstests: remove test expunge file support Dave Chinner
2013-03-23 10:19   ` Phil White
2013-03-15 12:27 ` [PATCH 09/25] xfstests: remove undocumented TESTS_REMAINING_LOG Dave Chinner
2013-03-23 10:20   ` Phil White
2013-03-15 12:27 ` [PATCH 10/25] xfstests: include test subdirectory support Dave Chinner
2013-03-23 10:20   ` Phil White
2013-03-15 12:27 ` [PATCH 11/25] xfstests: remove 285.full and 286.full Dave Chinner
2013-03-23 10:20   ` Phil White
2013-03-15 12:27 ` [PATCH 12/25] xfstests: move generic tests out of top level dir Dave Chinner
2013-03-23 10:22   ` Phil White
2013-03-15 12:27 ` [PATCH 13/25] xfstests: move xfs specific tests out of top directory Dave Chinner
2013-03-23 10:22   ` Phil White
2013-03-15 12:27 ` [PATCH 14/25] xfstests: move remaining tests out of top level directory Dave Chinner
2013-03-23 10:23   ` Phil White
2013-03-15 12:27 ` [PATCH 15/25] xfstests: rework CLI individual test specification Dave Chinner
2013-03-23 10:23   ` Phil White
2013-03-15 12:28 ` [PATCH 16/25] xfstests: make exclude groups aware of multiple subdirectories Dave Chinner
2013-03-23 10:23   ` Phil White
2013-03-15 12:28 ` [PATCH 17/25] xfstests: Introduce a results directory Dave Chinner
2013-03-23 10:23   ` Phil White
2013-03-15 12:28 ` [PATCH 18/25] xfstests: convert tests to use new " Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` [PATCH 19/25] xfstests: fix _link_out_file callers Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` [PATCH 20/25] xfstests: introduce a common directory Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` [PATCH 21/25] xfstests: Reintroduce configurable test expunging Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` [PATCH 22/25] xfstests: RESULTS_DIR needs to be an absolute path Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` [PATCH 23/25] xfstests: Decomplicate quota setup in 050 Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-15 12:28 ` Dave Chinner [this message]
2013-03-23 10:24   ` [PATCH 24/25] xfstests: clean up test 262 output file use Phil White
2013-03-15 12:28 ` [PATCH 25/25] xfstests: use _notrun for tape checks Dave Chinner
2013-03-23 10:24   ` Phil White
2013-03-27 10:51 ` [PATCH 00/25] xfstests: xfstests: move tests out of top level Rich Johnston
2013-03-27 10:51 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363350489-22257-25-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox