public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix the seq number in README
@ 2013-03-23 13:29 zwu.kernel
  2013-03-23 14:55 ` Eric Sandeen
  2013-03-25 13:52 ` Rich Johnston
  0 siblings, 2 replies; 3+ messages in thread
From: zwu.kernel @ 2013-03-23 13:29 UTC (permalink / raw)
  To: xfs; +Cc: Zhi Yong Wu

From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

  Although it is one very trivial bug, one patch is worth to
make it perfect.

Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README b/README
index b70f75d..2d231de 100644
--- a/README
+++ b/README
@@ -177,7 +177,7 @@ Test script environment:
 				  and the content of the NIS database
 				  if it is likely to be present)
 
-     4. General recommendations, usage conventions, etc.:
+     5. General recommendations, usage conventions, etc.:
 	- When the content of the password or group file is
 	  required, get it using the _cat_passwd and _cat_group
 	  functions, to ensure NIS information is included if NIS
-- 
1.7.11.7

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: fix the seq number in README
  2013-03-23 13:29 [PATCH] xfstests: fix the seq number in README zwu.kernel
@ 2013-03-23 14:55 ` Eric Sandeen
  2013-03-25 13:52 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2013-03-23 14:55 UTC (permalink / raw)
  To: zwu.kernel; +Cc: Zhi Yong Wu, xfs

On 3/23/13 8:29 AM, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
>   Although it is one very trivial bug, one patch is worth to
> make it perfect.
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

easy one ;)

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README b/README
> index b70f75d..2d231de 100644
> --- a/README
> +++ b/README
> @@ -177,7 +177,7 @@ Test script environment:
>  				  and the content of the NIS database
>  				  if it is likely to be present)
>  
> -     4. General recommendations, usage conventions, etc.:
> +     5. General recommendations, usage conventions, etc.:
>  	- When the content of the password or group file is
>  	  required, get it using the _cat_passwd and _cat_group
>  	  functions, to ensure NIS information is included if NIS
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: fix the seq number in README
  2013-03-23 13:29 [PATCH] xfstests: fix the seq number in README zwu.kernel
  2013-03-23 14:55 ` Eric Sandeen
@ 2013-03-25 13:52 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-03-25 13:52 UTC (permalink / raw)
  To: zwu.kernel; +Cc: Zhi Yong Wu, xfs

On 03/23/2013 08:29 AM, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
>    Although it is one very trivial bug, one patch is worth to
> make it perfect.
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>   README | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README b/README
> index b70f75d..2d231de 100644
> --- a/README
> +++ b/README
> @@ -177,7 +177,7 @@ Test script environment:
>   				  and the content of the NIS database
>   				  if it is likely to be present)
>
> -     4. General recommendations, usage conventions, etc.:
> +     5. General recommendations, usage conventions, etc.:
>   	- When the content of the password or group file is
>   	  required, get it using the _cat_passwd and _cat_group
>   	  functions, to ensure NIS information is included if NIS
>

Proper documentation is important thanks for the patch.
This patch has been committed.

Thanks
--Rich

commit dd1ee061a8784520287a7847c3404d719f46c854
Author: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Date:   Sat Mar 23 13:29:51 2013 +0000

     xfstests: fix the seq number in README


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-25 13:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-23 13:29 [PATCH] xfstests: fix the seq number in README zwu.kernel
2013-03-23 14:55 ` Eric Sandeen
2013-03-25 13:52 ` Rich Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox