From: Eryu Guan <eguan@redhat.com>
To: xfs@oss.sgi.com
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH 3/3] xfstests generic 310: fix common file path and other cleanups
Date: Sun, 7 Apr 2013 18:39:07 +0800 [thread overview]
Message-ID: <1365331147-15179-3-git-send-email-eguan@redhat.com> (raw)
In-Reply-To: <1365331147-15179-1-git-send-email-eguan@redhat.com>
1. add one space between # and test description
2. remove creator/owner info
3. fix common/rc and common/filter path so they can be sourced correctly
4. no need to remove $seq.full cause it's not used(or if verbose output
is needed, $seqres.full should be used)
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/generic/310 | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/tests/generic/310 b/tests/generic/310
index ef51422..35baa23 100644
--- a/tests/generic/310
+++ b/tests/generic/310
@@ -1,8 +1,8 @@
#! /bin/bash
# FS QA Test No. 310
#
-#Check if there are two threads,one keeps calling read() or lseek(), and
-#the other calling readdir(), both on the same directory fd.
+# Check if there are two threads,one keeps calling read() or lseek(), and
+# the other calling readdir(), both on the same directory fd.
#
# Based on a testcase from Li Zefan <lizefan@huawei.com>.
#
@@ -25,10 +25,9 @@
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
#
-# creator
-owner=zhaohongjiang@huawei.com
seq=`basename $0`
+seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
status=1 # failure is the default!
@@ -40,8 +39,8 @@ _cleanup()
trap "_cleanup; exit \$status" 0 1 2 3 15
# get standard environment, filters and checks
-. ./common.rc
-. ./common.filter
+. ./common/rc
+. ./common/filter
# real QA test starts here
_supported_fs generic
@@ -71,6 +70,5 @@ _test_lseek
# success, all done
echo "*** done"
-rm -f $seq.full
status=0
exit
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-04-07 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 10:39 [PATCH 1/3] xfstests: remove comments about creator in new Eryu Guan
2013-04-07 10:39 ` [PATCH 2/3] xfstests: replace $seq.full with $seqres.full in ext4/305 and generic/308 Eryu Guan
2013-04-08 13:01 ` Rich Johnston
2013-04-10 12:14 ` Rich Johnston
2013-04-07 10:39 ` Eryu Guan [this message]
2013-04-08 14:05 ` [PATCH 3/3] xfstests generic 310: fix common file path and other cleanups Rich Johnston
2013-04-09 5:29 ` Eryu Guan
2013-04-08 12:55 ` [PATCH 1/3] xfstests: remove comments about creator in new Rich Johnston
2013-04-10 12:12 ` Rich Johnston
-- strict thread matches above, loose matches on Subject: below --
2013-04-09 6:16 [PATCH 3/3] xfstests generic 310: fix common file path and other cleanups Zhao Hongjiang
2013-04-09 6:40 ` Dave Chinner
2013-04-09 7:25 ` Zhao Hongjiang
2013-04-09 12:00 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365331147-15179-3-git-send-email-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox