public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove()
Date: Thu, 25 Apr 2013 11:41:30 -0400	[thread overview]
Message-ID: <1366904490-46821-3-git-send-email-bfoster@redhat.com> (raw)
In-Reply-To: <1366904490-46821-1-git-send-email-bfoster@redhat.com>

From: Eric Sandeen <sandeen@redhat.com>

Include the global ino, ag number and agino in the warning message
emitted should xfs_imap() fail in the xfs_iunlink_remove() code
path.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 fs/xfs/xfs_inode.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index c22f980..a4fe989 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1678,8 +1678,10 @@ xfs_iunlink_remove(
 			error = xfs_imap(mp, tp, next_ino, &imap, 0);
 			if (error) {
 				xfs_warn(mp,
-	"%s: xfs_imap returned error %d.",
-					 __func__, error);
+					"%s: xfs_imap() returned error %d "
+					"for inode 0x%llx ag %d agino 0x%x",
+					__func__, error, ip->i_ino, agno, agino);
+
 				return error;
 			}
 
-- 
1.7.7.6

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-04-25 15:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 15:41 [PATCH 0/2] xfs: minor inode unlink debug enhancements Brian Foster
2013-04-25 15:41 ` [PATCH 1/2] xfs: tracepoints for xfs_iunlink() and xfs_iunlink_remove() Brian Foster
2013-04-26  2:19   ` Dave Chinner
2013-04-25 15:41 ` Brian Foster [this message]
2013-04-26  2:25   ` [PATCH 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove() Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366904490-46821-3-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox