* [PATCH v2 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove()
@ 2013-04-26 11:30 Brian Foster
2013-04-26 21:33 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Brian Foster @ 2013-04-26 11:30 UTC (permalink / raw)
To: xfs
From: Eric Sandeen <sandeen@redhat.com>
Include the global ino, ag number and agino in the warning message
emitted should xfs_imap() fail in the xfs_iunlink_remove() code
path.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
v2: Fix up indendation such that the string is on a single line.
fs/xfs/xfs_inode.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index c22f980..f00c6d1 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1678,8 +1678,10 @@ xfs_iunlink_remove(
error = xfs_imap(mp, tp, next_ino, &imap, 0);
if (error) {
xfs_warn(mp,
- "%s: xfs_imap returned error %d.",
- __func__, error);
+ "%s: xfs_imap() returned error %d for inode 0x%llx ag %d agino 0x%x",
+ __func__, error, ip->i_ino,
+ agno, agino);
+
return error;
}
--
1.7.7.6
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove()
2013-04-26 11:30 [PATCH v2 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove() Brian Foster
@ 2013-04-26 21:33 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2013-04-26 21:33 UTC (permalink / raw)
To: Brian Foster; +Cc: xfs
On Fri, Apr 26, 2013 at 07:30:13AM -0400, Brian Foster wrote:
> From: Eric Sandeen <sandeen@redhat.com>
>
> Include the global ino, ag number and agino in the warning message
> emitted should xfs_imap() fail in the xfs_iunlink_remove() code
> path.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks good now.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-26 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 11:30 [PATCH v2 2/2] xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove() Brian Foster
2013-04-26 21:33 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox