From: ranto.boris@gmail.com
To: xfs@oss.sgi.com
Cc: Boris Ranto <ranto.boris@gmail.com>
Subject: [PATCH 3/3] xfstests: Do not fail on empty exclude groups
Date: Thu, 2 May 2013 16:03:59 +0200 [thread overview]
Message-ID: <1367503439-12827-4-git-send-email-ranto.boris@gmail.com> (raw)
In-Reply-To: <1367503439-12827-1-git-send-email-ranto.boris@gmail.com>
From: Boris Ranto <ranto.boris@gmail.com>
Currently, xfstests will fail as soon as it detects an empty exclude
group. However, this may cause problems in automated testing. For
example, if one wishes to exclude otherwise valid group dmapi for file
system like tmpfs or nfs, the ./check script will hit the error about
empty group and fail. This simple patch changes the error to warning,
prints the warning to stderr and simply continue without excluding
anything as there are no tests to be excluded.
Signed-off-by: Boris Ranto <ranto.boris@gmail.com>
---
check | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/check b/check
index 4af2dbd..b888030 100755
--- a/check
+++ b/check
@@ -194,12 +194,13 @@ while [ $# -gt 0 ]; do
[ ! -s $tmp.list ] && get_all_tests
group_list=$(get_group_list $xgroup)
+ # Trim the test list only if there is something to trim it with
if [ -z "$group_list" ]; then
- echo "Group \"$xgroup\" is empty or not defined?"
- exit 1
+ echo "Warning: Group \"$xgroup\" seems empty." 1>&2
+ else
+ trim_test_list $group_list
fi
- trim_test_list $group_list
;;
-X) xfile=$2; shift ;
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-02 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 14:03 [PATCH 0/3] Tmpfs support and fixes for tmpfs/nfs ranto.boris
2013-05-02 14:03 ` [PATCH 1/3] xfstests: Add tmpfs support ranto.boris
2013-05-02 14:03 ` [PATCH 2/3] xfstests: Do not fail on non-existing tests/FSTYP directory ranto.boris
2013-05-02 14:03 ` ranto.boris [this message]
2013-05-13 12:57 ` [PATCH 0/3] Tmpfs support and fixes for tmpfs/nfs Boris Ranto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367503439-12827-4-git-send-email-ranto.boris@gmail.com \
--to=ranto.boris@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox