[PATCH 0/2] xfstests: more simple fixes...

[PATCH 0/2] xfstests: more simple fixes...

[Dave Chinner]

A couple of simple fixes - another redirection issue that I missed
on the last sweep (thanks Michael!), and a patch that disables quota
tests on relatime filesystems as realtime filesystems don't support
quotas.

Cheers,

Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 1/2] xfstests: fix incorrect redirect in generic/233

[Dave Chinner]

From: Dave Chinner <dchinner@redhat.com>

generic/233 attempts to direct output to tee, but instead of using a
pipe it uses an append operator. Hence it leaves a file named "tee"
in the root directory of the xfstests execution path. Just direct
the output to the $seqres.full file rather than trying to tee it
into the test output as well.

Reported-by: "Michael L. Semon" <mlsemon35@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/generic/233 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/233 b/tests/generic/233
index 2b6cd2f..58b3672 100755
--- a/tests/generic/233
+++ b/tests/generic/233
@@ -62,7 +62,7 @@ _fsstress()
 -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
 -n $count -d $out -p 7`
 
-	echo "fsstress $args" >> tee -a $seqres.full
+	echo "fsstress $args" >> $seqres.full
 	if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | _filter_num
 	then
 		echo "    fsstress $args returned $?"
-- 
1.7.10.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 1/2] xfstests: fix incorrect redirect in generic/233

[Eric Sandeen]

On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> generic/233 attempts to direct output to tee, but instead of using a
> pipe it uses an append operator. Hence it leaves a file named "tee"
> in the root directory of the xfstests execution path. Just direct
> the output to the $seqres.full file rather than trying to tee it
> into the test output as well.
> 
> Reported-by: "Michael L. Semon" <mlsemon35@gmail.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/generic/233 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/233 b/tests/generic/233
> index 2b6cd2f..58b3672 100755
> --- a/tests/generic/233
> +++ b/tests/generic/233
> @@ -62,7 +62,7 @@ _fsstress()
>  -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
>  -n $count -d $out -p 7`
>  
> -	echo "fsstress $args" >> tee -a $seqres.full
> +	echo "fsstress $args" >> $seqres.full
>  	if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | _filter_num
>  	then
>  		echo "    fsstress $args returned $?"
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 1/2] xfstests: fix incorrect redirect in generic/233

[Rich Johnston]

On 05/08/2013 01:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> generic/233 attempts to direct output to tee, but instead of using a
> pipe it uses an append operator. Hence it leaves a file named "tee"
> in the root directory of the xfstests execution path. Just direct
> the output to the $seqres.full file rather than trying to tee it
> into the test output as well.
>

This patch has been committed:

commit ef6b44446143e7bea4ef17b4493e23ca1cdb64b2
Author: Dave Chinner <dchinner@redhat.com>
Date:   Tue May 14 08:34:44 2013 -0500

     xfstests: fix incorrect redirect in generic/233

Thanks
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 2/2] xfstests: quota not supported on realtime filesystems

[Dave Chinner]

From: Dave Chinner <dchinner@redhat.com>

Realtime XFS filesystems do not support quotas, so quota tests
always fail on such filesystems. Add a check to _require_quota to
detect this situation and notrun the quota tests...

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 common/quota |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/quota b/common/quota
index fd5374f..3550cd4 100644
--- a/common/quota
+++ b/common/quota
@@ -40,6 +40,12 @@ _require_quota()
 	if [ ! -f /proc/fs/xfs/xqmstat ]; then
 	    _notrun "Installed kernel does not support XFS quotas"
         fi
+	if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
+	    _notrun "Quotas not supported on realtime test device"
+	fi
+	if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
+	    _notrun "Quotas not supported on realtime scratch device"
+	fi
 	;;
     *)
 	_notrun "disk quotas not supported by this filesystem type: $FSTYP"
-- 
1.7.10.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems

[Eric Sandeen]

On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Realtime XFS filesystems do not support quotas, so quota tests
> always fail on such filesystems. Add a check to _require_quota to
> detect this situation and notrun the quota tests...
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

(PS why is USE_EXTERNAL a thing?  if it's set, shouldn't it be used?)

-Eric

> ---
>  common/quota |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/quota b/common/quota
> index fd5374f..3550cd4 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -40,6 +40,12 @@ _require_quota()
>  	if [ ! -f /proc/fs/xfs/xqmstat ]; then
>  	    _notrun "Installed kernel does not support XFS quotas"
>          fi
> +	if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> +	    _notrun "Quotas not supported on realtime test device"
> +	fi
> +	if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> +	    _notrun "Quotas not supported on realtime scratch device"
> +	fi
>  	;;
>      *)
>  	_notrun "disk quotas not supported by this filesystem type: $FSTYP"
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems

[Dave Chinner]

On Wed, May 08, 2013 at 09:37:25AM -0500, Eric Sandeen wrote:
> On 5/8/13 1:04 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > Realtime XFS filesystems do not support quotas, so quota tests
> > always fail on such filesystems. Add a check to _require_quota to
> > detect this situation and notrun the quota tests...
> > 
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> 
> (PS why is USE_EXTERNAL a thing?  if it's set, shouldn't it be used?)

Because if you have rtdev/logdev defined in your config, you can
choose whether to test them or not without having to modify the
config file. Very handy, really.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs