From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id CD11929E3B for ; Fri, 17 May 2013 06:14:07 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 8CC028F8035 for ; Fri, 17 May 2013 04:14:07 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id dIPKGrgt5G8hx5jj for ; Fri, 17 May 2013 04:14:06 -0700 (PDT) Received: from disappointment ([192.168.1.1]) by dastard with esmtp (Exim 4.76) (envelope-from ) id 1UdIbm-0008Sx-TU for xfs@oss.sgi.com; Fri, 17 May 2013 21:13:58 +1000 Received: from dave by disappointment with local (Exim 4.80) (envelope-from ) id 1UdIbm-0005Fq-O4 for xfs@oss.sgi.com; Fri, 17 May 2013 21:13:58 +1000 From: Dave Chinner Subject: [PATCH 26/30] xfsprogs: disable xfs_check for CRC enabled filesystems Date: Fri, 17 May 2013 21:13:21 +1000 Message-Id: <1368789205-19969-27-git-send-email-david@fromorbit.com> In-Reply-To: <1368789205-19969-1-git-send-email-david@fromorbit.com> References: <1368789205-19969-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com From: Dave Chinner Until xfs_db has full metadata CRC support, xfs_check will not be able to fully verify filesystems in this format. Don't even bother trying right now, and to make it simple to test full xfsprogs installs with xfstests, just silently succeed. Signed-off-by: Dave Chinner --- db/check.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/db/check.c b/db/check.c index 5b7498f..dadfa97 100644 --- a/db/check.c +++ b/db/check.c @@ -788,6 +788,20 @@ blockget_f( dbprintf(_("already have block usage information\n")); return 0; } + + /* + * XXX: check does not support CRC enabled filesystems. Return + * immediately, silently, with success but without doing anything here + * initially so that xfstests can run without modification on metadata + * enabled filesystems. + * + * XXX: ultimately we need to dump an error message here that xfstests + * filters out, or we need to actually do the work to make check support + * crc enabled filesystems. + */ + if (xfs_sb_version_hascrc(&mp->m_sb)) + return 0; + if (!init(argc, argv)) { if (serious_error) exitcode = 3; -- 1.7.10.4 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs