Re: [PATCH 00/11] xfs: fixes for 3.10-rc3

Ben Myers
2013-05-21T16:26:48Z

Hi Dave,

On Tue, May 21, 2013 at 06:01:59PM +1000, Dave Chinner wrote:
> This is my current kernel bug fix patch series. I've updated it
> against a current xfsdev tree, and contains all the fixes mentioned
> in the "fixes for 3.10-rc2 (updated)" thread. The first 7 patches
> are patches from that series. The last 4 are new patches.
>
> The first new patch stops CRC enabled filesystems from spamming the
> log. It currently emits an "Experimental" warning ever time the
> superblock is written, which is typically every 30s.
>
> The second path ("rework remote attr CRCs") is the changes I
> mentioned in the "fixes for 3.10-rc2 (updated)" thread. The code is
> far more robust as a result of these changes, and I think we really
> need to change the format as done in this patch. Once we have
> decided on the way forward, I'll port this to userspace.
>
> The third patch fixes a remote symlink problem - I didn't hit this
> until I'd redone the remote attr CRCs and the 1k block size
> filesystem testing made it passed the attribute tests it was failing
> on.
>
> Finally, the last patch is another on-disk format change - one that
> removes the 25 entry limit on ACLs. It doesn't invalidate anything
> that is already on disk, just allows ACLs on v5 superblock
> filesystems to store more than 25 ACLs in an xattr. In fact, it
> allows (65536 - 4) / 12 = 5461 entries to be stored in a single
> ACL, so I don't see anyone running out on v5 superblocks....
>
> Thoughts, comments?

I'll look into these but I am concerned that we're starting to get into 3.11
territory. We'll see how the reviews go. FWIW I have no objection to changing
the on-disk format at any time until the 'experimental' tag is removed.

Regards,
Ben